[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21581 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-20 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21581#discussion_r196707308 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3082,7 +3082,10 @@ object functions { * @since 1.5.0 */

[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21581#discussion_r196649798 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3082,7 +3082,10 @@ object functions { * @since 1.5.0 */

[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21581#discussion_r196636915 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3082,7 +3082,10 @@ object functions { * @since 1.5.0 */

[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21581#discussion_r196636085 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3082,7 +3082,10 @@ object functions { * @since 1.5.0 */

[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21581#discussion_r196633968 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -571,6 +571,10 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #21581: [SPARK-24574][SQL] array_contains, array_position...

2018-06-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21581#discussion_r196633908 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3082,7 +3082,10 @@ object functions { * @since 1.5.0 */