[GitHub] spark pull request #21693: [SPARK-24673][SQL] scala sql function from_utc_ti...

2018-07-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21693#discussion_r200419437 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2934,6 +2934,17 @@ object functions { FromUTCTimestamp(ts.expr, Li

[GitHub] spark pull request #21693: [SPARK-24673][SQL] scala sql function from_utc_ti...

2018-07-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21693 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21693: [SPARK-24673][SQL] scala sql function from_utc_ti...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21693#discussion_r200264684 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2934,6 +2934,17 @@ object functions { FromUTCTimestamp(ts.expr, L

[GitHub] spark pull request #21693: [SPARK-24673][SQL] scala sql function from_utc_ti...

2018-07-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21693#discussion_r199744569 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2934,6 +2934,17 @@ object functions { FromUTCTimestamp(ts.expr, Litera

[GitHub] spark pull request #21693: [SPARK-24673][SQL] scala sql function from_utc_ti...

2018-07-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21693#discussion_r199744502 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2945,6 +2956,17 @@ object functions { ToUTCTimestamp(ts.expr, Literal(