[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix type coercions and nullabi...

2018-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21704 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix type coercions and nullabi...

2018-07-13 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r202278265 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -259,8 +270,22 @@ object TypeCoercion { }

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix type coercions and nullabi...

2018-07-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r202064680 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -259,8 +270,22 @@ object TypeCoercion {

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix type coercions and nullabi...

2018-07-12 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r202002501 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -184,6 +184,17 @@ object TypeCoercion { }

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix type coercions and nullabi...

2018-07-12 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r202001514 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -179,11 +180,13 @@ case class

[GitHub] spark pull request #21704: [SPARK-24734][SQL] Fix type coercions and nullabi...

2018-07-12 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21704#discussion_r201924130 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -610,27 +636,27 @@ object TypeCoercion {