[GitHub] spark pull request #22038: [SPARK-25056][SQL] Unify the InConversion and Bin...

2018-09-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22038#discussion_r220989953 --- Diff: sql/core/src/test/resources/sql-tests/results/typeCoercion/native/inConversion.sql.out --- @@ -69,7 +69,7 @@ true -- !query 8

[GitHub] spark pull request #22038: [SPARK-25056][SQL] Unify the InConversion and Bin...

2018-09-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22038#discussion_r217603577 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -485,8 +494,8 @@ object TypeCoercion {

[GitHub] spark pull request #22038: [SPARK-25056][SQL] Unify the InConversion and Bin...

2018-08-10 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22038#discussion_r209163143 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -1378,8 +1378,8 @@ class TypeCoercionSuite

[GitHub] spark pull request #22038: [SPARK-25056][SQL] Unify the InConversion and Bin...

2018-08-09 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22038#discussion_r208833322 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -486,9 +486,17 @@ object TypeCoercion {

[GitHub] spark pull request #22038: [SPARK-25056][SQL] Unify the InConversion and Bin...

2018-08-08 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/22038 [SPARK-25056][SQL] Unify the InConversion and BinaryComparison behaviour when InConversion's list only contains one datatype ## What changes were proposed in this pull request? before this PR: