Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22390
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22390#discussion_r216739580
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -263,10 +263,12 @@ object BooleanSimplificatio
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22390#discussion_r216713161
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -263,10 +263,12 @@ object BooleanSimplification e
Github user adrian-ionescu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22390#discussion_r216587787
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -263,10 +263,12 @@ object BooleanSimplificati
Github user adrian-ionescu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22390#discussion_r216587101
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -263,10 +263,12 @@ object BooleanSimplificati
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22390#discussion_r216576135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -263,10 +263,12 @@ object BooleanSimplificatio
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22390#discussion_r216574955
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
---
@@ -48,6 +48,14 @@ class BooleanSi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22390#discussion_r216575397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -263,10 +263,12 @@ object BooleanSimplification ex
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22390#discussion_r216575336
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
---
@@ -48,6 +48,14 @@ class BooleanSi
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22390
[SPARK-25402][SQL] Null handling in BooleanSimplification
## What changes were proposed in this pull request?
This PR is to fix the null handling in BooleanSimplification. In the rule
Boolea
10 matches
Mail list logo