[GitHub] spark pull request #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in ...

2018-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22454 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in ...

2018-09-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22454#discussion_r218567663 --- Diff: dev/create-release/release-build.sh --- @@ -446,6 +432,8 @@ if [[ "$1" == "publish-release" ]]; then # Clean-up Zinc nailgun process $

[GitHub] spark pull request #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in ...

2018-09-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22454#discussion_r218497767 --- Diff: dev/create-release/release-build.sh --- @@ -446,6 +432,8 @@ if [[ "$1" == "publish-release" ]]; then # Clean-up Zinc nailgun process

[GitHub] spark pull request #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in ...

2018-09-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22454#discussion_r218496294 --- Diff: dev/create-release/release-build.sh --- @@ -305,16 +290,17 @@ if [[ "$1" == "package" ]]; then for key in ${!BINARY_PKGS_ARGS[@]}; do