Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22513
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22513#discussion_r219414758
--- Diff:
core/src/main/scala/org/apache/spark/sql/execution/benchmark/BenchmarkBase.scala
---
@@ -15,7 +15,7 @@
* limitations under the License.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22513#discussion_r219414641
--- Diff:
core/src/main/scala/org/apache/spark/sql/execution/benchmark/Benchmark.scala ---
@@ -15,7 +15,7 @@
* limitations under the License.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22513#discussion_r219397646
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala
---
@@ -27,7 +27,7 @@ import
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22513#discussion_r219388085
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala
---
@@ -27,7 +27,7 @@ import
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22513
[SPARK-25499][TEST]Refactor BenchmarkBase and Benchmark
## What changes were proposed in this pull request?
Currently there are two classes with the same naming BenchmarkBase:
1.