Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22544
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220772034
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class Element
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220766294
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -974,6 +974,25 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220765052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -974,6 +974,25 @@ object TypeCoercion {
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220746708
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -974,6 +974,33 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220533930
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class Element
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220532183
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -974,6 +974,33 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220531899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -974,6 +974,33 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220460094
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -257,12 +257,48 @@ class TypeCoercionSuite exten
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220459877
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -257,12 +257,48 @@ class TypeCoercionSuite exten
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220456613
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,38 @@ object TypeCoercion {
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220452656
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,38 @@ object TypeCoercion {
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220445443
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,38 @@ object TypeCoercion {
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220452974
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,38 @@ object TypeCoercion {
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220253485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion {
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220250631
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion {
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220250338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class Eleme
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220244473
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220241139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class ElementAt(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220232666
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class Eleme
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220193922
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class ElementAt(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220140660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220140252
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220147139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion {
24 matches
Mail list logo
