[GitHub] spark pull request #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22589 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22589#discussion_r221440760 --- Diff: R/pkg/tests/run-all.R --- @@ -18,50 +18,55 @@ library(testthat) library(SparkR) -# Turn all warnings into errors

[GitHub] spark pull request #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22589#discussion_r221424365 --- Diff: R/pkg/tests/run-all.R --- @@ -18,50 +18,55 @@ library(testthat) library(SparkR) -# Turn all warnings into errors

[GitHub] spark pull request #22589: [SPARK-25572][SPARKR] test only if not cran

2018-09-28 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/22589 [SPARK-25572][SPARKR] test only if not cran ## What changes were proposed in this pull request? CRAN doesn't seem to respect the system requirements as running tests - we have seen