[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222520483 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222510592 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222510006 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala --- @@ -517,4 +517,93 @@ class SQLMetricsSuite extends

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222368401 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala --- @@ -517,4 +517,93 @@ class SQLMetricsSuite extends

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222354699 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -397,7 +397,7 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222351322 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222345983 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222343539 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222342196 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222341169 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222330998 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222337687 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala --- @@ -517,4 +517,93 @@ class SQLMetricsSuite extends

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222320450 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -250,7 +250,9 @@ abstract class SparkPlan extends

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222334931 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222319861 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/22621 [SPARK-25602][SQL] range metrics can be wrong if the result rows are not fully consumed ## What changes were proposed in this pull request? This is a long-standing bug. When `Range` is