[GitHub] spark pull request #22637: [SPARK-25408] Move to more ideomatic Java8

2018-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22637 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22637: [SPARK-25408] Move to more ideomatic Java8

2018-10-06 Thread Fokko
Github user Fokko commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r223196616 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/CLIService.java --- @@ -154,6 +154,7 @@ public synchronized void start() {

[GitHub] spark pull request #22637: [SPARK-25408] Move to more ideomatic Java8

2018-10-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r223188294 --- Diff: sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java --- @@ -152,31 +151,24 @@ public void emptyBa

[GitHub] spark pull request #22637: [SPARK-25408] Move to more ideomatic Java8

2018-10-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r223188308 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/CLIService.java --- @@ -154,6 +154,7 @@ public synchronized void start() {

[GitHub] spark pull request #22637: [SPARK-25408] Move to more ideomatic Java8

2018-10-06 Thread Fokko
Github user Fokko commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r223187949 --- Diff: sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java --- @@ -152,31 +151,27 @@ public void emptyBat

[GitHub] spark pull request #22637: [SPARK-25408] Move to more ideomatic Java8

2018-10-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r223187058 --- Diff: sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java --- @@ -152,31 +151,27 @@ public void emptyBa