Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22766
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22766#discussion_r226511589
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
---
@@ -340,39 +340,39 @@ private[hive] case class HiveUDAFFunction(
r
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22766#discussion_r226511506
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
---
@@ -340,39 +340,39 @@ private[hive] case class HiveUDAFFunction(
r
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22766#discussion_r226511479
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
---
@@ -340,39 +340,39 @@ private[hive] case class HiveUDAFFunction(
r
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22766#discussion_r226375347
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
---
@@ -339,40 +339,38 @@ private[hive] case class HiveUDAFFunction(
v
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22766#discussion_r226346524
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
---
@@ -339,40 +339,38 @@ private[hive] case class HiveUDAFFunction(
va
Github user peter-toth commented on a diff in the pull request:
https://github.com/apache/spark/pull/22766#discussion_r226345858
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
---
@@ -339,40 +339,38 @@ private[hive] case class HiveUDAFFunction(
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22766#discussion_r226319445
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -638,6 +638,21 @@ class HiveUDFSuite extends QueryTest wit
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22766#discussion_r226319210
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -638,6 +638,21 @@ class HiveUDFSuite extends QueryTest wit
GitHub user peter-toth opened a pull request:
https://github.com/apache/spark/pull/22766
[SPARK-25768][SQL] fix constant argument expecting UDAFs
## What changes were proposed in this pull request?
This change makes all fields of `HiveUDAFFunction` lazy.
## How was
10 matches
Mail list logo