[GitHub] spark pull request #22828: [SPARK-25832][SQL] Remove newly added map related...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/22828 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22828: [SPARK-25832][SQL] remove newly added map related...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22828#discussion_r228259220 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java --- @@ -61,8 +61,6 @@ */ public final class

[GitHub] spark pull request #22828: [SPARK-25832][SQL] remove newly added map related...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22828#discussion_r228258092 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -433,13 +432,9 @@ object FunctionRegistry

[GitHub] spark pull request #22828: [SPARK-25832][SQL] remove newly added map related...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22828#discussion_r228257902 --- Diff: python/pyspark/sql/functions.py --- @@ -2540,26 +2540,6 @@ def map_values(col): return

[GitHub] spark pull request #22828: [SPARK-25832][SQL] remove newly added map related...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22828#discussion_r228257685 --- Diff: R/pkg/NAMESPACE --- @@ -313,7 +313,6 @@ exportMethods("%<=>%", "lower", "lpad",

[GitHub] spark pull request #22828: [SPARK-25832][SQL] remove newly added map related...

2018-10-25 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/22828 [SPARK-25832][SQL] remove newly added map related functions ## What changes were proposed in this pull request? This aims to supercede https://github.com/apache/spark/pull/22821 .