Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22898
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22898#discussion_r229667653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -124,14 +124,9 @@ object ExpressionEncoder {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22898#discussion_r229631397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -124,14 +124,9 @@ object ExpressionEncoder {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22898#discussion_r229619306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -124,14 +124,9 @@ object ExpressionEncoder {
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22898
[SPARK-25746][SQL][followup] do not add unnecessary If expression
## What changes were proposed in this pull request?
a followup of https://github.com/apache/spark/pull/22749.
Wh