[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-20 Thread ramaddepally
Github user ramaddepally commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r235109184 --- Diff: bin/docker-image-tool.sh --- @@ -41,6 +41,18 @@ function image_ref { echo "$image" } +function docker_push { + loca

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-20 Thread ramaddepally
Github user ramaddepally commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r235108733 --- Diff: bin/docker-image-tool.sh --- @@ -102,33 +114,37 @@ function build { error "Failed to build Spark JVM Docker image, please refer to Do

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-20 Thread ramaddepally
Github user ramaddepally commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r235108873 --- Diff: bin/docker-image-tool.sh --- @@ -41,6 +41,18 @@ function image_ref { echo "$image" } +function docker_push { + loca

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-20 Thread ramaddepally
Github user ramaddepally commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r235108574 --- Diff: bin/docker-image-tool.sh --- @@ -102,33 +114,37 @@ function build { error "Failed to build Spark JVM Docker image, please refer to Do

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-20 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r234968357 --- Diff: bin/docker-image-tool.sh --- @@ -41,6 +41,18 @@ function image_ref { echo "$image" } +function docker_push { + local imag

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-20 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r234967639 --- Diff: bin/docker-image-tool.sh --- @@ -102,33 +114,37 @@ function build { error "Failed to build Spark JVM Docker image, please refer to Docker

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-20 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r234968130 --- Diff: bin/docker-image-tool.sh --- @@ -102,33 +114,37 @@ function build { error "Failed to build Spark JVM Docker image, please refer to Docker

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-20 Thread rvesse
Github user rvesse commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r234968048 --- Diff: bin/docker-image-tool.sh --- @@ -41,6 +41,18 @@ function image_ref { echo "$image" } +function docker_push { + local imag

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-16 Thread ramaddepally
Github user ramaddepally commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r234335016 --- Diff: bin/docker-image-tool.sh --- @@ -102,33 +114,33 @@ function build { error "Failed to build Spark JVM Docker image, please refer to Do

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-16 Thread ramaddepally
Github user ramaddepally commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r234334875 --- Diff: bin/docker-image-tool.sh --- @@ -145,6 +157,8 @@ Options: -f file Dockerfile to build for JVM based Jobs. By default bui

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r234325912 --- Diff: bin/docker-image-tool.sh --- @@ -145,6 +157,8 @@ Options: -f file Dockerfile to build for JVM based Jobs. By default builds th

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23053#discussion_r234326069 --- Diff: bin/docker-image-tool.sh --- @@ -102,33 +114,33 @@ function build { error "Failed to build Spark JVM Docker image, please refer to Docker

[GitHub] spark pull request #23053: [SPARK-25957][K8S] Add ability to skip building o...

2018-11-15 Thread ramaddepally
GitHub user ramaddepally opened a pull request: https://github.com/apache/spark/pull/23053 [SPARK-25957][K8S] Add ability to skip building optional k8s docker i… …mages ## What changes were proposed in this pull request? bin/docker-image-tool.sh tries to build all docker