[GitHub] yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.

2018-12-24 Thread GitBox
yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming. URL: https://github.com/apache/spark/pull/23369#issuecomment-449782786 @dongjoon-hyun , code style issues fixed done. Please help to review again. Thanks. --

[GitHub] yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.

2018-12-27 Thread GitBox
yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming. URL: https://github.com/apache/spark/pull/23369#issuecomment-450103024 As I can see in the source code, for this patch, the use of `StreamingWriteSupportProvider` and `StreamingWriteSupport` is

[GitHub] yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.

2018-12-28 Thread GitBox
yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming. URL: https://github.com/apache/spark/pull/23369#issuecomment-450315514 OK, I will follow the doc. Thanks. This is an automated me

[GitHub] yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.

2019-01-13 Thread GitBox
yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming. URL: https://github.com/apache/spark/pull/23369#issuecomment-453889754 Considerating there exists similary patchs before, I will close this patch. Thanks for your guys. ---

[GitHub] yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.

2019-01-14 Thread GitBox
yanlin-Lynn commented on issue #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming. URL: https://github.com/apache/spark/pull/23369#issuecomment-453953424 > Why don’t you consider bahir? It’s an Apache project and it has other SS sink or source for Spark. I think it's OK