Re: [PR] [SPARK-37448][SQL] Multiple performance optimizations related to CurrentOrigin.withOrigin [spark]

2024-06-07 Thread via GitHub
JoshRosen commented on code in PR #46908: URL: https://github.com/apache/spark/pull/46908#discussion_r1630802165 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -315,32 +317,34 @@ trait ColumnResolutionHelper extends

Re: [PR] [SPARK-37448][SQL] Multiple performance optimizations related to CurrentOrigin.withOrigin [spark]

2024-06-07 Thread via GitHub
JoshRosen commented on code in PR #46908: URL: https://github.com/apache/spark/pull/46908#discussion_r1630821788 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala: ## @@ -343,8 +343,14 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]

Re: [PR] [SPARK-37448][SQL] Multiple performance optimizations related to CurrentOrigin.withOrigin [spark]

2024-06-07 Thread via GitHub
JoshRosen commented on code in PR #46908: URL: https://github.com/apache/spark/pull/46908#discussion_r1630802165 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -315,32 +317,34 @@ trait ColumnResolutionHelper extends

Re: [PR] [SPARK-37448][SQL] Multiple performance optimizations related to CurrentOrigin.withOrigin [spark]

2024-06-07 Thread via GitHub
JoshRosen commented on code in PR #46908: URL: https://github.com/apache/spark/pull/46908#discussion_r1630802165 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -315,32 +317,34 @@ trait ColumnResolutionHelper extends

Re: [PR] [SPARK-37448][SQL] Multiple performance optimizations related to CurrentOrigin.withOrigin [spark]

2024-06-07 Thread via GitHub
JoshRosen commented on code in PR #46908: URL: https://github.com/apache/spark/pull/46908#discussion_r1630802165 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -315,32 +317,34 @@ trait ColumnResolutionHelper extends

Re: [PR] [SPARK-37448][SQL] Multiple performance optimizations related to CurrentOrigin.withOrigin [spark]

2024-06-07 Thread via GitHub
JoshRosen commented on code in PR #46908: URL: https://github.com/apache/spark/pull/46908#discussion_r1630802165 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -315,32 +317,34 @@ trait ColumnResolutionHelper extends

Re: [PR] [SPARK-37448][SQL] Multiple performance optimizations related to CurrentOrigin.withOrigin [spark]

2024-06-06 Thread via GitHub
JoshRosen commented on code in PR #46908: URL: https://github.com/apache/spark/pull/46908#discussion_r1630419417 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala: ## @@ -139,62 +139,64 @@ trait ColumnResolutionHelper extends

[PR] [SPARK-37448][SQL] Multiple performance optimizations related to CurrentOrigin.withOrigin [spark]

2024-06-06 Thread via GitHub
JoshRosen opened a new pull request, #46908: URL: https://github.com/apache/spark/pull/46908 ### What changes were proposed in this pull request? This PR implements multiple performance optimizations related to `CurrentOrigin.withOrigin`. Avoiding `withOrigin` in cases