[PR] [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer [spark]

2023-11-12 Thread via GitHub
Hisoka-X opened a new pull request, #41156: URL: https://github.com/apache/spark/pull/41156 ### What changes were proposed in this pull request? The example here is multiplying Decimal(38, 10) by another Decimal(38, 10), but I think it can be reproduced with other number combi

Re: [PR] [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer [spark]

2023-11-10 Thread via GitHub
github-actions[bot] commented on PR #41156: URL: https://github.com/apache/spark/pull/41156#issuecomment-1806588426 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

Re: [PR] [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer [spark]

2023-11-11 Thread via GitHub
github-actions[bot] closed pull request #41156: [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer URL: https://github.com/apache/spark/pull/41156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer [spark]

2023-11-12 Thread via GitHub
beliefer commented on PR #41156: URL: https://github.com/apache/spark/pull/41156#issuecomment-1807354887 cc @cloud-fan It seems https://github.com/apache/spark/pull/43678 is similar to this one. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer [spark]

2023-11-12 Thread via GitHub
beliefer commented on code in PR #41156: URL: https://github.com/apache/spark/pull/41156#discussion_r1390553794 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ## @@ -279,7 +282,7 @@ abstract class BinaryArithmetic extends BinaryOperato

Re: [PR] [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer [spark]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #41156: URL: https://github.com/apache/spark/pull/41156#issuecomment-1958435583 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

Re: [PR] [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer [spark]

2024-02-22 Thread via GitHub
github-actions[bot] closed pull request #41156: [SPARK-40129][SQL] Fix Decimal multiply can produce the wrong answer URL: https://github.com/apache/spark/pull/41156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL