MaxGekk commented on PR #45183:
URL: https://github.com/apache/spark/pull/45183#issuecomment-1959005351
@nikolamand-db Congratulations with your first contribution to Apache Spark!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MaxGekk closed pull request #45183: [SPARK-42328][SQL] Remove
_LEGACY_ERROR_TEMP_1175 from error classes
URL: https://github.com/apache/spark/pull/45183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
MaxGekk commented on PR #45183:
URL: https://github.com/apache/spark/pull/45183#issuecomment-1959002002
+1, LGTM. Merging to master.
Thank you, @nikolamand-db and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
MaxGekk commented on code in PR #45183:
URL: https://github.com/apache/spark/pull/45183#discussion_r1498113092
##
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##
@@ -1908,8 +1908,9 @@ private[sql] object QueryCompilationErrors extends
MaxGekk commented on code in PR #45183:
URL: https://github.com/apache/spark/pull/45183#discussion_r1498113092
##
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##
@@ -1908,8 +1908,9 @@ private[sql] object QueryCompilationErrors extends
nikolamand-db commented on code in PR #45183:
URL: https://github.com/apache/spark/pull/45183#discussion_r1497906728
##
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala:
##
@@ -962,6 +963,22 @@ class QueryCompilationErrorsSuite
MaxGekk commented on code in PR #45183:
URL: https://github.com/apache/spark/pull/45183#discussion_r1497387505
##
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala:
##
@@ -962,6 +963,22 @@ class QueryCompilationErrorsSuite
MaxGekk commented on code in PR #45183:
URL: https://github.com/apache/spark/pull/45183#discussion_r1497386712
##
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##
@@ -1908,8 +1908,8 @@ private[sql] object QueryCompilationErrors extends
nikolamand-db opened a new pull request, #45183:
URL: https://github.com/apache/spark/pull/45183
### What changes were proposed in this pull request?
Error class `_LEGACY_ERROR_TEMP_1175` indicates "unsupported data type".
There is already an error class covering this case
