dongjoon-hyun commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2060677068
The vote passed.
- https://lists.apache.org/thread/4cbkpvc3vr3b6k0wp6lgsw37spdpnqrc
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the
yaooqinn commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2054658700
@gengliangwang than you for the detailed explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2053817569
Thank you all. For the record, the vote is started.
- [[VOTE] SPARK-4: Use ANSI SQL mode by
default](https://lists.apache.org/thread/l2qhpfgtfv6gf001vgw677wylhmx9gcb)
--
mridulm commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2053492527
+CC @shardulm94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gengliangwang commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2052657458
@yaooqinn enabling the ANSI SQL mode does address certain unreasonable SQL
behaviors, such as integer overflow and division by zero, which could
potentially disrupt users'
amaliujia commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2052308167
Will this be included into any maintenance release that is cut before Spark
4? I assume no?
--
This is an automated message from the Apache Git Service.
To respond to the message,
yaooqinn commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050953196
> Many of the workloads will just fail in the parser/analyzer and the
failures are not related to data quality issues. Also, there is no easy
workaround like "try_*" functions.
gengliangwang commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050941358
>And what about the default values of the ANI-related sub-configurations,
such as
spark.sql.ansi.enforceReservedKeywords
spark.sql.ansi.relationPrecedence
yaooqinn commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050928965
https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html should be
updated too.
And what about the default values of the ANI-related sub-configurations,
such as
-
dongjoon-hyun commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050903327
Yes, I want to have AS-IS implementation and to define clear boundary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050899887
Yea there are still some gaps between Spark ANSI mode and the SQL standard.
But mostly ANSI is still a better default than no ANSI at all.
yaooqinn commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050882987
Thank you @dongjoon-hyun for raising that thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dongjoon-hyun commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050875592
Thank you for the feedback, @yaooqinn .
Yes, I totally understand the situation. The reason why I raise this issue
is to make a decision (go/no-go) for this item.
yaooqinn commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050867779
I have added the above link and issues to SPARK-4.
I didn't continue to audit ANSI compatibility as SPARK-46374 didn't get much
attention.
--
This is an automated message
dongjoon-hyun commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050839565
Ya, could you add them all to the PR description and SPARK-4, @yaooqinn ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yaooqinn commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050839295
https://dev.mysql.com/doc/refman/8.3/en/sql-mode.html
It seems that ANSI mode stays OFF in MySQL 8
--
This is an automated message from the Apache Git Service.
To respond to the
yaooqinn commented on PR #46013:
URL: https://github.com/apache/spark/pull/46013#issuecomment-2050833640
There are still many behaviors incompatible w/ ANSI standard, such as
SPARK-46374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dongjoon-hyun opened a new pull request, #46013:
URL: https://github.com/apache/spark/pull/46013
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
###
18 matches
Mail list logo
