Re: [PR] [SPARK-44837][SQL] Improve ALTER TABLE ALTER PARTITION column error message [spark]

2023-10-17 Thread via GitHub
beliefer commented on code in PR #42524: URL: https://github.com/apache/spark/pull/42524#discussion_r1361853134 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -377,7 +377,10 @@ case class AlterTableChangeColumnCommand( val resolver =

Re: [PR] [SPARK-44837][SQL] Improve ALTER TABLE ALTER PARTITION column error message [spark]

2023-10-13 Thread via GitHub
beliefer commented on code in PR #42524: URL: https://github.com/apache/spark/pull/42524#discussion_r1359145115 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -377,8 +377,13 @@ case class AlterTableChangeColumnCommand( val resolver =

Re: [PR] [SPARK-44837][SQL] Improve ALTER TABLE ALTER PARTITION column error message [spark]

2023-10-12 Thread via GitHub
MaxGekk commented on PR #42524: URL: https://github.com/apache/spark/pull/42524#issuecomment-1759782127 Seems like a related test failure: ``` [info] - Error classes match with document *** FAILED *** (209 milliseconds) [info] "... table ``[.] [info] [info] ###

Re: [PR] [SPARK-44837][SQL] Improve ALTER TABLE ALTER PARTITION column error message [spark]

2023-10-10 Thread via GitHub
MaxGekk commented on code in PR #42524: URL: https://github.com/apache/spark/pull/42524#discussion_r1353982630 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -97,6 +97,12 @@ "The method can not be called on streaming Dataset/DataFrame." ] },

Re: [PR] [SPARK-44837][SQL] Improve ALTER TABLE ALTER PARTITION column error message [spark]

2023-10-10 Thread via GitHub
MaxGekk commented on code in PR #42524: URL: https://github.com/apache/spark/pull/42524#discussion_r1353981939 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -97,6 +97,12 @@ "The method can not be called on streaming Dataset/DataFrame." ] },

Re: [PR] [SPARK-44837][SQL] Improve ALTER TABLE ALTER PARTITION column error message [spark]

2023-10-09 Thread via GitHub
holdenk commented on code in PR #42524: URL: https://github.com/apache/spark/pull/42524#discussion_r1351065858 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -97,6 +97,12 @@ "The method can not be called on streaming Dataset/DataFrame." ] },

Re: [PR] [SPARK-44837][SQL] Improve ALTER TABLE ALTER PARTITION column error message [spark]

2023-10-09 Thread via GitHub
MaxGekk commented on code in PR #42524: URL: https://github.com/apache/spark/pull/42524#discussion_r1350588319 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -415,13 +417,21 @@ case class AlterTableChangeColumnCommand( Seq.empty[Row]