Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

zml1206 commented on PR #43144: URL: https://github.com/apache/spark/pull/43144#issuecomment-1880631838 Thank you for review. @cloud-fan @beliefer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

cloud-fan closed pull request #43144: [SPARK-45352][SQL] Eliminate foldable window partitions URL: https://github.com/apache/spark/pull/43144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

cloud-fan commented on PR #43144: URL: https://github.com/apache/spark/pull/43144#issuecomment-1880625597 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

beliefer commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1440353552 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateWindowPartitionsSuite.scala: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

zml1206 commented on PR #43144: URL: https://github.com/apache/spark/pull/43144#issuecomment-1875093495 Updated all, CI runs completed, but the page display is still running. @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

cloud-fan commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1440109131 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala: ## @@ -548,4 +548,18 @@ class DataFrameWindowFramesSuite extends QueryTest with

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

cloud-fan commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1440108285 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateWindowPartitionsSuite.scala: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

cloud-fan commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1440108568 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateWindowPartitionsSuite.scala: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

cloud-fan commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1440107589 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateWindowPartitions.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

zml1206 commented on PR #43144: URL: https://github.com/apache/spark/pull/43144#issuecomment-1873652051 @cloud-fan Already fixed unit test, could you have time to take a look？Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

zml1206 commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1437087368 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala: ## @@ -548,4 +548,19 @@ class DataFrameWindowFramesSuite extends QueryTest with

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

zml1206 commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1437087042 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1251,6 +1252,24 @@ object OptimizeRepartition extends Rule[LogicalPlan]

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

zml1206 commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1437087242 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala: ## @@ -548,4 +548,19 @@ class DataFrameWindowFramesSuite extends QueryTest with

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

cloud-fan commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1437007194 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala: ## @@ -548,4 +548,19 @@ class DataFrameWindowFramesSuite extends QueryTest with

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

cloud-fan commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1437006206 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala: ## @@ -548,4 +548,19 @@ class DataFrameWindowFramesSuite extends QueryTest with

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

cloud-fan commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1437005120 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1251,6 +1252,24 @@ object OptimizeRepartition extends

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

zml1206 commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1436460406 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1241,6 +1242,24 @@ object OptimizeRepartition extends Rule[LogicalPlan]

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

beliefer commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1377081807 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1241,6 +1242,24 @@ object OptimizeRepartition extends Rule[LogicalPlan]

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

zml1206 commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1377013427 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1241,6 +1242,24 @@ object OptimizeRepartition extends Rule[LogicalPlan]

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

beliefer commented on PR #43144: URL: https://github.com/apache/spark/pull/43144#issuecomment-1785081862 cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

beliefer commented on code in PR #43144: URL: https://github.com/apache/spark/pull/43144#discussion_r1376121522 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1241,6 +1242,24 @@ object OptimizeRepartition extends Rule[LogicalPlan]

Re: [PR] [SPARK-45352][SQL] Eliminate foldable window partitions [spark]

zml1206 commented on PR #43144: URL: https://github.com/apache/spark/pull/43144#issuecomment-1784359968 cc @wangyum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To