panbingkun commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1788247942
It's strange that I haven't received any notification about this PR until
today when I received the 'resolved' email on Jira.
--
This is an automated message from the Apache Git
panbingkun commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1788238152
late LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
srowen closed pull request #43456: [SPARK-45368][SQL] Remove scala2.12
compatibility logic for DoubleType, FloatType, Decimal
URL: https://github.com/apache/spark/pull/43456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
srowen commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1787246774
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
laglangyue commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1786451271
@srowen @amaliujia @HyukjinKwon PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
laglangyue commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1782342252
> > @amaliujia cc. shoudl `asIntegral` be removed for
PhysicalFractionalType, float and double , I find the method not be used. if
shoudle not removed,should we add this. `implicit
amaliujia commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1782304036
> @amaliujia cc. shoudl `asIntegral` be removed for PhysicalFractionalType,
float and double , I find the method not be used. if shoudle not removed,should
we add this. `implicit
laglangyue commented on code in PR #43456:
URL: https://github.com/apache/spark/pull/43456#discussion_r1374062779
##
sql/api/src/main/scala/org/apache/spark/sql/types/FloatType.scala:
##
@@ -41,37 +39,4 @@ class FloatType private() extends FractionalType {
* @since 1.3.0
*/
srowen commented on code in PR #43456:
URL: https://github.com/apache/spark/pull/43456#discussion_r1373180796
##
sql/api/src/main/scala/org/apache/spark/sql/types/FloatType.scala:
##
@@ -41,37 +39,4 @@ class FloatType private() extends FractionalType {
* @since 1.3.0
*/
laglangyue commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1781070727
@panbingkun @srowen
Hi, hope to get your help.
If Scala 2.12 is completely removed and only Scala 2.13 is used, is it
necessary to remove the `asIntegral` method from the
laglangyue commented on code in PR #43456:
URL: https://github.com/apache/spark/pull/43456#discussion_r1373118025
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/PhysicalDataType.scala:
##
@@ -92,7 +92,6 @@ object PhysicalNumericType {
sealed abstract
laglangyue commented on code in PR #43456:
URL: https://github.com/apache/spark/pull/43456#discussion_r1373117603
##
sql/api/src/main/scala/org/apache/spark/sql/types/DoubleType.scala:
##
@@ -40,34 +38,4 @@ class DoubleType private() extends FractionalType {
* @since 1.3.0
laglangyue commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1775200284
@amaliujia cc.
shoudl `asIntegral` be removed for PhysicalFractionalType, float and double
, I find the method not be used.
if shoudle not removed,should we add this.
laglangyue commented on code in PR #43456:
URL: https://github.com/apache/spark/pull/43456#discussion_r1368662550
##
sql/api/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##
@@ -681,8 +681,6 @@ object Decimal {
override def toLong(x: Decimal): Long = x.toLong
srowen commented on code in PR #43456:
URL: https://github.com/apache/spark/pull/43456#discussion_r1368659888
##
sql/api/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##
@@ -681,8 +681,6 @@ object Decimal {
override def toLong(x: Decimal): Long = x.toLong
laglangyue commented on code in PR #43456:
URL: https://github.com/apache/spark/pull/43456#discussion_r1368648303
##
sql/api/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##
@@ -681,8 +681,6 @@ object Decimal {
override def toLong(x: Decimal): Long = x.toLong
srowen commented on code in PR #43456:
URL: https://github.com/apache/spark/pull/43456#discussion_r1368591778
##
sql/api/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##
@@ -681,8 +681,6 @@ object Decimal {
override def toLong(x: Decimal): Long = x.toLong
laglangyue commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1774715007
Let me correct my previous description.
Based on SPARK-30011,[SPARK-43110] [SQL] Move asIntegral to PhysicalDataType
Revised. Removed the implementation of asIntegral in double
HyukjinKwon commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1774309585
cc @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
laglangyue commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1773760515
according to PR and `scala.math.Numeric.BigDecimalAsIfIntegral`
https://github.com/apache/spark/pull/26769/files
When we drop scala 2.12, all we just need to remove the comments.
laglangyue closed pull request #43456: [SPARK-45368][SQL] Remove scala2.12
compatibility logic for DoubleType, FloatType, Decimal
URL: https://github.com/apache/spark/pull/43456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
laglangyue commented on PR #43456:
URL: https://github.com/apache/spark/pull/43456#issuecomment-1773068036
I found that `asIntegral` was not used, PhysicalDecimalType.asIntegral was
used directly, rather than through trait.
--
This is an automated message from the Apache Git Service.
To
22 matches
Mail list logo
