dongjoon-hyun commented on PR #43283:
URL: https://github.com/apache/spark/pull/43283#issuecomment-1753566223
Merged to master for Apache Spark 4.0.0. Thank you, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
dongjoon-hyun closed pull request #43283: [SPARK-45452][SQL][FOLLOWUP] Simplify
path check logic
URL: https://github.com/apache/spark/pull/43283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dongjoon-hyun commented on code in PR #43283:
URL: https://github.com/apache/spark/pull/43283#discussion_r1350719313
##
core/src/test/scala/org/apache/spark/util/HadoopFSUtilsSuite.scala:
##
@@ -30,4 +30,36 @@ class HadoopFSUtilsSuite extends SparkFunSuite {
assert(HadoopFS
viirya commented on code in PR #43283:
URL: https://github.com/apache/spark/pull/43283#discussion_r1350544362
##
core/src/test/scala/org/apache/spark/util/HadoopFSUtilsSuite.scala:
##
@@ -30,4 +30,36 @@ class HadoopFSUtilsSuite extends SparkFunSuite {
assert(HadoopFSUtils.s
viirya commented on PR #43283:
URL: https://github.com/apache/spark/pull/43283#issuecomment-1753337006
Looks good to me now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dongjoon-hyun commented on PR #43283:
URL: https://github.com/apache/spark/pull/43283#issuecomment-1752488372
The regular expression is updated and new test cases are added. Thank you so
much, @viirya .
```
[info] HadoopFSUtilsSuite:
[info] - HadoopFSUtils - file filtering (14 milli
dongjoon-hyun commented on code in PR #43283:
URL: https://github.com/apache/spark/pull/43283#discussion_r1349933327
##
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##
@@ -342,13 +344,24 @@ private[spark] object HadoopFSUtils extends Logging {
exclude && !
viirya commented on code in PR #43283:
URL: https://github.com/apache/spark/pull/43283#discussion_r1349869031
##
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##
@@ -342,13 +344,24 @@ private[spark] object HadoopFSUtils extends Logging {
exclude && !include
dongjoon-hyun commented on PR #43283:
URL: https://github.com/apache/spark/pull/43283#issuecomment-1752266746
Thank you for review, @viirya . The PR is updated~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
dongjoon-hyun commented on code in PR #43283:
URL: https://github.com/apache/spark/pull/43283#discussion_r1349820345
##
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##
@@ -342,13 +345,24 @@ private[spark] object HadoopFSUtils extends Logging {
exclude && !
dongjoon-hyun commented on code in PR #43283:
URL: https://github.com/apache/spark/pull/43283#discussion_r1349819977
##
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##
@@ -342,13 +345,24 @@ private[spark] object HadoopFSUtils extends Logging {
exclude && !
viirya commented on code in PR #43283:
URL: https://github.com/apache/spark/pull/43283#discussion_r1349817037
##
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##
@@ -342,13 +345,24 @@ private[spark] object HadoopFSUtils extends Logging {
exclude && !include
viirya commented on code in PR #43283:
URL: https://github.com/apache/spark/pull/43283#discussion_r1349816592
##
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##
@@ -342,13 +345,24 @@ private[spark] object HadoopFSUtils extends Logging {
exclude && !include
viirya commented on code in PR #43283:
URL: https://github.com/apache/spark/pull/43283#discussion_r1349814837
##
core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala:
##
@@ -30,6 +31,7 @@ import org.apache.spark._
import org.apache.spark.internal.Logging
import org.ap
dongjoon-hyun commented on PR #43283:
URL: https://github.com/apache/spark/pull/43283#issuecomment-1752162962
Could you review this follow-up, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dongjoon-hyun opened a new pull request, #43283:
URL: https://github.com/apache/spark/pull/43283
### What changes were proposed in this pull request?
This is a follow-up of #43261 to simplify path check logic and add more test
coverage.
### Why are the changes needed?
To
16 matches
Mail list logo
