dongjoon-hyun commented on PR #43302:
URL: https://github.com/apache/spark/pull/43302#issuecomment-1755861171
Thank you, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
viirya commented on PR #43302:
URL: https://github.com/apache/spark/pull/43302#issuecomment-1755763667
Backport PRs: https://github.com/apache/spark/pull/43315 (3.5),
https://github.com/apache/spark/pull/43316 (3.4).
--
This is an automated message from the Apache Git Service.
To respond
viirya commented on PR #43302:
URL: https://github.com/apache/spark/pull/43302#issuecomment-1755749609
Thanks @dongjoon-hyun . Sure, let me create backport PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
dongjoon-hyun commented on PR #43302:
URL: https://github.com/apache/spark/pull/43302#issuecomment-1754628232
Merged to master.
There is a minor conflict in branch-3.5 due to quoting. Could you make
backporting PRs, @viirya ?
--
This is an automated message from the Apache Git Serv
dongjoon-hyun closed pull request #43302: [SPARK-45473][SQL] Fix incorrect
error message for RoundBase
URL: https://github.com/apache/spark/pull/43302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
viirya commented on PR #43302:
URL: https://github.com/apache/spark/pull/43302#issuecomment-1754467148
Thank you @holdenk @beliefer @dongjoon-hyun @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
viirya commented on code in PR #43302:
URL: https://github.com/apache/spark/pull/43302#discussion_r1351517603
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala:
##
@@ -963,4 +964,18 @@ class MathExpressionsSuite extends SparkFunS
MaxGekk commented on code in PR #43302:
URL: https://github.com/apache/spark/pull/43302#discussion_r1351508855
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala:
##
@@ -963,4 +964,18 @@ class MathExpressionsSuite extends SparkFun
viirya commented on PR #43302:
URL: https://github.com/apache/spark/pull/43302#issuecomment-1754393924
Thanks @dongjoon-hyun . I've fixed `ExpressionTypeCheckingSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
holdenk commented on PR #43302:
URL: https://github.com/apache/spark/pull/43302#issuecomment-1754111612
LGTM pending CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
10 matches
Mail list logo
