Re: [PR] [SPARK-45534] Use java.lang.ref.Cleaner instead of finalize for RemoteBlockPushResolver [spark]

2023-10-15 Thread via GitHub
zhaomin1423 commented on code in PR #43371: URL: https://github.com/apache/spark/pull/43371#discussion_r1359908418 ## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java: ## @@ -1756,6 +1759,8 @@ public static class AppShufflePartit

Re: [PR] [SPARK-45534] Use java.lang.ref.Cleaner instead of finalize for RemoteBlockPushResolver [spark]

2023-10-15 Thread via GitHub
LuciferYang commented on code in PR #43371: URL: https://github.com/apache/spark/pull/43371#discussion_r1359905254 ## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java: ## @@ -1756,6 +1759,8 @@ public static class AppShufflePartit

Re: [PR] [SPARK-45534] Use java.lang.ref.Cleaner instead of finalize for RemoteBlockPushResolver [spark]

2023-10-15 Thread via GitHub
LuciferYang commented on code in PR #43371: URL: https://github.com/apache/spark/pull/43371#discussion_r1359905254 ## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java: ## @@ -1756,6 +1759,8 @@ public static class AppShufflePartit

Re: [PR] [SPARK-45534] Use java.lang.ref.Cleaner instead of finalize for RemoteBlockPushResolver [spark]

2023-10-15 Thread via GitHub
zhaomin1423 commented on code in PR #43371: URL: https://github.com/apache/spark/pull/43371#discussion_r1359901730 ## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java: ## @@ -1756,6 +1759,8 @@ public static class AppShufflePartit

Re: [PR] [SPARK-45534] Use java.lang.ref.Cleaner instead of finalize for RemoteBlockPushResolver [spark]

2023-10-13 Thread via GitHub
beliefer commented on code in PR #43371: URL: https://github.com/apache/spark/pull/43371#discussion_r1359110742 ## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java: ## @@ -1933,6 +1933,39 @@ public RoaringBitmap getMapTracker() {

Re: [PR] [SPARK-45534] Use java.lang.ref.Cleaner instead of finalize for RemoteBlockPushResolver [spark]

2023-10-13 Thread via GitHub
LuciferYang commented on code in PR #43371: URL: https://github.com/apache/spark/pull/43371#discussion_r1359100137 ## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java: ## @@ -1933,6 +1933,39 @@ public RoaringBitmap getMapTracker(

Re: [PR] [SPARK-45534] Use java.lang.ref.Cleaner instead of finalize for RemoteBlockPushResolver [spark]

2023-10-13 Thread via GitHub
LuciferYang commented on PR #43371: URL: https://github.com/apache/spark/pull/43371#issuecomment-1762504715 cc @mridulm FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-45534] Use java.lang.ref.Cleaner instead of finalize for RemoteBlockPushResolver [spark]

2023-10-13 Thread via GitHub
zhaomin1423 commented on PR #43371: URL: https://github.com/apache/spark/pull/43371#issuecomment-1762485442 Please help me review it. @LuciferYang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to