Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-11-01 Thread via GitHub
HyukjinKwon closed pull request #43546: [SPARK-45680][CONNECT] Release session URL: https://github.com/apache/spark/pull/43546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-11-01 Thread via GitHub
HyukjinKwon commented on PR #43546: URL: https://github.com/apache/spark/pull/43546#issuecomment-1789860912 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-11-01 Thread via GitHub
HyukjinKwon commented on PR #43546: URL: https://github.com/apache/spark/pull/43546#issuecomment-1788579388 rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-11-01 Thread via GitHub
HyukjinKwon commented on PR #43546: URL: https://github.com/apache/spark/pull/43546#issuecomment-1788501357 The test should pass now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-31 Thread via GitHub
HyukjinKwon commented on PR #43546: URL: https://github.com/apache/spark/pull/43546#issuecomment-1788436733 hmmm .. `test_error_enrichment_jvm_stacktrace` seems a real test failure too. lemme take a look soon -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-31 Thread via GitHub
HyukjinKwon commented on PR #43546: URL: https://github.com/apache/spark/pull/43546#issuecomment-1788264993 I pushed some changes but I think you should take a look ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-31 Thread via GitHub
HyukjinKwon commented on code in PR #43546: URL: https://github.com/apache/spark/pull/43546#discussion_r1378300936 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -667,6 +667,7 @@ class SparkSession private[sql] ( * @since 3.4.0

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-31 Thread via GitHub
HyukjinKwon commented on code in PR #43546: URL: https://github.com/apache/spark/pull/43546#discussion_r1378300602 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -667,6 +667,7 @@ class SparkSession private[sql] ( * @since 3.4.0

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-31 Thread via GitHub
HyukjinKwon commented on code in PR #43546: URL: https://github.com/apache/spark/pull/43546#discussion_r1378275852 ## python/pyspark/sql/tests/connect/test_connect_basic.py: ## @@ -3451,7 +3451,6 @@ def test_can_create_multiple_sessions_to_different_remotes(self): #

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-31 Thread via GitHub
juliuszsompolski commented on code in PR #43546: URL: https://github.com/apache/spark/pull/43546#discussion_r1377960758 ## python/pyspark/sql/tests/connect/test_connect_basic.py: ## @@ -3451,7 +3451,6 @@ def test_can_create_multiple_sessions_to_different_remotes(self):

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-30 Thread via GitHub
HyukjinKwon commented on PR #43546: URL: https://github.com/apache/spark/pull/43546#issuecomment-1786230748 I think we might need to retrigger ... https://github.com/juliuszsompolski/apache-spark/actions/runs/6695859696/job/18192423072 -- This is an automated message from the Apache Git

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-30 Thread via GitHub
hvanhovell commented on PR #43546: URL: https://github.com/apache/spark/pull/43546#issuecomment-1786225354 @HyukjinKwon is this the same python test issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-30 Thread via GitHub
juliuszsompolski commented on code in PR #43546: URL: https://github.com/apache/spark/pull/43546#discussion_r1376366601 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -667,6 +667,7 @@ class SparkSession private[sql] ( * @since

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-30 Thread via GitHub
heyihong commented on code in PR #43546: URL: https://github.com/apache/spark/pull/43546#discussion_r1376290191 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -667,6 +667,7 @@ class SparkSession private[sql] ( * @since 3.4.0

Re: [PR] [SPARK-45680][CONNECT] Release session [spark]

2023-10-30 Thread via GitHub
heyihong commented on code in PR #43546: URL: https://github.com/apache/spark/pull/43546#discussion_r1376290689 ## python/pyspark/sql/connect/session.py: ## @@ -654,6 +654,7 @@ def stop(self) -> None: # multi-tenancy - the remote client side cannot just stop the server