LuciferYang commented on PR #43603:
URL: https://github.com/apache/spark/pull/43603#issuecomment-1822059435
Merged into master for Spark 4.0. Thanks @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
LuciferYang closed pull request #43603: [SPARK-45697][BUILD] Fix `Unicode
escapes in triple quoted strings are deprecated`
URL: https://github.com/apache/spark/pull/43603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
panbingkun commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1400127824
##
pom.xml:
##
@@ -3000,6 +3000,7 @@
reduce the cost of migration in subsequent versions.
-->
panbingkun commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1400127824
##
pom.xml:
##
@@ -3000,6 +3000,7 @@
reduce the cost of migration in subsequent versions.
-->
LuciferYang commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1400114822
##
pom.xml:
##
@@ -3000,6 +3000,7 @@
reduce the cost of migration in subsequent versions.
-->
LuciferYang commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1398632990
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##
@@ -1678,7 +1680,8 @@ class PlanParserSuite extends AnalysisTest {
panbingkun commented on PR #43603:
URL: https://github.com/apache/spark/pull/43603#issuecomment-1815962947
> To clarify: I am more inclined to understand the original intent of the
test. If the goal is just to test different separators, we can use the literals
of visible separators to
LuciferYang commented on PR #43603:
URL: https://github.com/apache/spark/pull/43603#issuecomment-1815724730
I am more inclined to understand the original intent of the test. If the
goal is just to test different separators, we can use the literals of visible
separators to eliminate this
panbingkun commented on PR #43603:
URL: https://github.com/apache/spark/pull/43603#issuecomment-1815468435
> May I ask the status of this PR, @panbingkun ?
@dongjoon-hyun
My modification principle is to `eliminate the warning` and `maintain the
original string semantics`, but it is
panbingkun commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1382737960
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##
@@ -1677,25 +1677,23 @@ class PlanParserSuite extends AnalysisTest {
panbingkun commented on PR #43603:
URL: https://github.com/apache/spark/pull/43603#issuecomment-1793996377
https://github.com/apache/spark/assets/15246973/209d7924-7867-4cf0-b3fc-8cf4f4019faf;>
https://github.com/apache/spark/assets/15246973/24aef12e-dd13-414f-b324-77e0466b8fb9;>
panbingkun commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1378454613
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##
@@ -1677,25 +1677,24 @@ class PlanParserSuite extends AnalysisTest {
LuciferYang commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1378423078
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##
@@ -1677,25 +1677,24 @@ class PlanParserSuite extends AnalysisTest {
LuciferYang commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1378421435
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##
@@ -1677,25 +1677,24 @@ class PlanParserSuite extends AnalysisTest {
panbingkun commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1378349936
##
project/SparkBuild.scala:
##
@@ -269,7 +269,8 @@ object SparkBuild extends PomBuild {
// SPARK-45627 `enum`, `export` and `given` will become keywords
panbingkun commented on PR #43603:
URL: https://github.com/apache/spark/pull/43603#issuecomment-1788304312
https://github.com/apache/spark/assets/15246973/76a23c09-cd87-4eeb-bca4-ec01fda4000d;>
https://github.com/apache/spark/assets/15246973/1ebfb343-a1ae-46bc-a690-b02c93612b34;>
panbingkun commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1378302898
##
project/SparkBuild.scala:
##
@@ -269,7 +269,8 @@ object SparkBuild extends PomBuild {
// SPARK-45627 `enum`, `export` and `given` will become keywords
LuciferYang commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1377847272
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##
@@ -1678,23 +1678,27 @@ class PlanParserSuite extends AnalysisTest {
LuciferYang commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1377847272
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##
@@ -1678,23 +1678,27 @@ class PlanParserSuite extends AnalysisTest {
LuciferYang commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1377847272
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##
@@ -1678,23 +1678,27 @@ class PlanParserSuite extends AnalysisTest {
LuciferYang commented on code in PR #43603:
URL: https://github.com/apache/spark/pull/43603#discussion_r1377813437
##
project/SparkBuild.scala:
##
@@ -269,7 +269,8 @@ object SparkBuild extends PomBuild {
// SPARK-45627 `enum`, `export` and `given` will become keywords
panbingkun opened a new pull request, #43603:
URL: https://github.com/apache/spark/pull/43603
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
22 matches
Mail list logo
