Re: [PR] [SPARK-45710][SQL] Assign names to error _LEGACY_ERROR_TEMP_21[59,60,61,62] [spark]

2023-11-05 Thread via GitHub
MaxGekk closed pull request #43567: [SPARK-45710][SQL] Assign names to error _LEGACY_ERROR_TEMP_21[59,60,61,62] URL: https://github.com/apache/spark/pull/43567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-45710][SQL] Assign names to error _LEGACY_ERROR_TEMP_21[59,60,61,62] [spark]

2023-11-05 Thread via GitHub
MaxGekk commented on PR #43567: URL: https://github.com/apache/spark/pull/43567#issuecomment-1793792762 The failed python GA is not related to the changes, and it passed a couple commits above. +1, LGTM. Merging to master. Thank you, @dengziming. -- This is an automated message

Re: [PR] [SPARK-45710][SQL] Assign names to error _LEGACY_ERROR_TEMP_21[59,60,61,62] [spark]

2023-11-05 Thread via GitHub
MaxGekk commented on code in PR #43567: URL: https://github.com/apache/spark/pull/43567#discussion_r1382526287 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala: ## @@ -2586,13 +2577,14 @@ private[sql] object QueryExecutionErrors extends

Re: [PR] [SPARK-45710][SQL] Assign names to error _LEGACY_ERROR_TEMP_21[59,60,61,62] [spark]

2023-11-04 Thread via GitHub
MaxGekk commented on code in PR #43567: URL: https://github.com/apache/spark/pull/43567#discussion_r1382362098 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -405,6 +405,29 @@ ], "sqlState" : "42704" }, + "COLLECTION_SIZE_LIMIT_EXCEEDED" : { +

Re: [PR] [SPARK-45710][SQL] Assign names to error _LEGACY_ERROR_TEMP_21[59,60,61,62] [spark]

2023-10-27 Thread via GitHub
dengziming commented on PR #43567: URL: https://github.com/apache/spark/pull/43567#issuecomment-1783686054 The use of the 4 similar errors is a bit confusing, we have separate errors for flatten/concat/union, but we are using `CREATE_XXX` for array_repeat/array_insert/array_distinct/...

[PR] [SPARK-45710][SQL] Assign names to error _LEGACY_ERROR_TEMP_21[59,60,61,62] [spark]

2023-10-27 Thread via GitHub
dengziming opened a new pull request, #43567: URL: https://github.com/apache/spark/pull/43567 ### What changes were proposed in this pull request? The 4 errors are `[CONCAT/FLATTEN/CREATE/UNION]_ARRAYS_WITH_ELEMENTS_EXCEED_LIMIT`, CONCAT_XXX is used in concat/array_insert;