Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

peter-toth commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1390209748 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

peter-toth commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1390209748 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

peter-toth commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1390209748 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan closed pull request #43614: [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 URL: https://github.com/apache/spark/pull/43614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on PR #43614: URL: https://github.com/apache/spark/pull/43614#issuecomment-1803285997 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1387469464 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -148,15 +148,39 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

amaliujia commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1387214224 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

beliefer commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386517887 ## sql/core/src/test/scala/org/apache/spark/sql/CTEInlineSuite.scala: ## @@ -678,6 +678,17 @@ abstract class CTEInlineSuiteBase }.isDefined, "CTE columns

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

beliefer commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386496786 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386445439 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

peter-toth commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386283978 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386083968 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -148,6 +148,21 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386083447 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386082741 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -148,6 +148,21 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386083113 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386081658 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -156,7 +171,15 @@ trait CheckAnalysis extends PredicateHelper with

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386079358 ## sql/core/src/test/scala/org/apache/spark/sql/CTEInlineSuite.scala: ## @@ -678,6 +678,17 @@ abstract class CTEInlineSuiteBase }.isDefined, "CTE columns

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

amaliujia commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1386031378 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala: ## @@ -120,6 +120,30 @@ case class InlineCTE(alwaysInline: Boolean = false)

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

amaliujia commented on PR #43614: URL: https://github.com/apache/spark/pull/43614#issuecomment-1801142041 The code has been updated. Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

peter-toth commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1381488547 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala: ## @@ -120,6 +120,30 @@ case class InlineCTE(alwaysInline: Boolean = false)

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

peter-toth commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1381488547 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala: ## @@ -120,6 +120,30 @@ case class InlineCTE(alwaysInline: Boolean = false)

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

beliefer commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1378685716 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala: ## @@ -120,6 +120,30 @@ case class InlineCTE(alwaysInline: Boolean = false)

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1378488137 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala: ## @@ -120,6 +120,30 @@ case class InlineCTE(alwaysInline: Boolean = false)

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

cloud-fan commented on code in PR #43614: URL: https://github.com/apache/spark/pull/43614#discussion_r1378485861 ## sql/core/src/test/scala/org/apache/spark/sql/CTEInlineSuite.scala: ## @@ -678,6 +678,17 @@ abstract class CTEInlineSuiteBase }.isDefined, "CTE columns

Re: [PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

amaliujia commented on PR #43614: URL: https://github.com/apache/spark/pull/43614#issuecomment-1788420163 @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [SPARK-45752][SQL] Unreferenced CTE should all be checked by CheckAnalysis0 [spark]

amaliujia opened a new pull request, #43614: URL: https://github.com/apache/spark/pull/43614 ### What changes were proposed in this pull request? This PR fixes an issue that if a CTE is referenced by a non-referenced CTE, then this CTE should also have ref count as 0 and