beliefer commented on PR #43786:
URL: https://github.com/apache/spark/pull/43786#issuecomment-1857368908
I will close due to https://github.com/apache/spark/pull/44184 merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
beliefer closed pull request #43786: [SPARK-45904][SQL][CONNECT] Mode function
should supports sort with order direction
URL: https://github.com/apache/spark/pull/43786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
cloud-fan commented on code in PR #43786:
URL: https://github.com/apache/spark/pull/43786#discussion_r1393889797
##
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##
@@ -842,19 +842,20 @@ object functions {
* @group agg_funcs
* @since
beliefer commented on PR #43786:
URL: https://github.com/apache/spark/pull/43786#issuecomment-1811910009
The GA failure is unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
beliefer commented on PR #43786:
URL: https://github.com/apache/spark/pull/43786#issuecomment-1811662016
ping @MaxGekk cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
beliefer commented on PR #43786:
URL: https://github.com/apache/spark/pull/43786#issuecomment-1809870537
> @beliefer, are you referring to the `isSortAsc` argument of the mode
function or are you referring to the new `MODE() WITHIN GROUP (ORDER BY col
[ASC|DESC])` syntax by "mainstream
peter-toth commented on PR #43786:
URL: https://github.com/apache/spark/pull/43786#issuecomment-1809732959
Actually this is literally the same implementation I came up with internally
before I added deterministic mode in
https://github.com/apache/spark/pull/42755. But then we reduced the
beliefer commented on code in PR #43786:
URL: https://github.com/apache/spark/pull/43786#discussion_r1391141072
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##
@@ -54,52 +51,28 @@ case class Mode(
child: Expression,
beliefer commented on code in PR #43786:
URL: https://github.com/apache/spark/pull/43786#discussion_r1391141072
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##
@@ -54,52 +51,28 @@ case class Mode(
child: Expression,
beliefer opened a new pull request, #43786:
URL: https://github.com/apache/spark/pull/43786
### What changes were proposed in this pull request?
Currently, the mode aggregate function only support sort desc with the input
column.
But the mainstream database (e.g. H2 and Postgres)
10 matches
Mail list logo