LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1777189371
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/Aggregation.java:
##
@@ -28,16 +28,7 @@
* @since 3.2.0
*/
@Evolving
-public
cloud-fan commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1777185239
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/Aggregation.java:
##
@@ -28,16 +28,7 @@
* @since 3.2.0
*/
@Evolving
-public fi
LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1777165654
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/Aggregation.java:
##
@@ -28,16 +28,7 @@
* @since 3.2.0
*/
@Evolving
-public
LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1777165654
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/Aggregation.java:
##
@@ -28,16 +28,7 @@
* @since 3.2.0
*/
@Evolving
-public
LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1777165654
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/Aggregation.java:
##
@@ -28,16 +28,7 @@
* @since 3.2.0
*/
@Evolving
-public
LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1777165654
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/Aggregation.java:
##
@@ -28,16 +28,7 @@
* @since 3.2.0
*/
@Evolving
-public
cloud-fan commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1776924601
##
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/Aggregation.java:
##
@@ -28,16 +28,7 @@
* @since 3.2.0
*/
@Evolving
-public fi
dongjoon-hyun commented on PR #43796:
URL: https://github.com/apache/spark/pull/43796#issuecomment-1813954802
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
dongjoon-hyun closed pull request #43796: [SPARK-45919][CORE][SQL] Use Java 16
`record` to simplify Java class definition
URL: https://github.com/apache/spark/pull/43796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
LuciferYang commented on PR #43796:
URL: https://github.com/apache/spark/pull/43796#issuecomment-1813710853
rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
LuciferYang commented on PR #43796:
URL: https://github.com/apache/spark/pull/43796#issuecomment-1812528892
wait https://github.com/apache/spark/pull/43817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1394074332
##
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RemoteBlockPushResolverSuite.java:
##
@@ -1612,19 +1612,8 @@ private void verifyMetrics(
LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1394064308
##
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java:
##
@@ -153,24 +153,6 @@ private static ShuffleServiceMetricsInfo
LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1394067701
##
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RemoteBlockPushResolverSuite.java:
##
@@ -1612,19 +1612,8 @@ private void verifyMetrics(
LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1394064308
##
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java:
##
@@ -153,24 +153,6 @@ private static ShuffleServiceMetricsInfo
dongjoon-hyun commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1394022682
##
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java:
##
@@ -153,24 +153,6 @@ private static ShuffleServiceMetricsInf
dongjoon-hyun commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1394018312
##
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RemoteBlockPushResolverSuite.java:
##
@@ -1612,19 +1612,8 @@ private void verifyMetrics(
LuciferYang commented on PR #43796:
URL: https://github.com/apache/spark/pull/43796#issuecomment-1812139559
> > @dongjoon-hyun I want to clarify the issue. We don't want to use
`record` here because `field` in the original class doesn't provide an
Accessor, but since `record` automatically
dongjoon-hyun commented on PR #43796:
URL: https://github.com/apache/spark/pull/43796#issuecomment-1812013863
> @dongjoon-hyun I want to clarify the issue. We don't want to use `record`
here because `field` in the original class doesn't provide an Accessor, but
since `record` automatically
LuciferYang commented on PR #43796:
URL: https://github.com/apache/spark/pull/43796#issuecomment-1811959949
@dongjoon-hyun I want to clarify the issue. We don't want to use `record`
here because `field` in the original class doesn't provide an Accessor, but
since `record` automatically gene
LuciferYang commented on PR #43796:
URL: https://github.com/apache/spark/pull/43796#issuecomment-1811951525
> This is a nice syntax in general, @LuciferYang .
>
> However, we cannot use this when the class provides information hiding.
>
> ```java
> jshell> private static clas
LuciferYang commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1393752725
##
common/network-common/src/main/java/org/apache/spark/network/protocol/StreamChunkId.java:
##
@@ -26,14 +26,7 @@
/**
* Encapsulates a request for a particular c
dongjoon-hyun commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1393751280
##
common/network-common/src/main/java/org/apache/spark/network/protocol/StreamChunkId.java:
##
@@ -26,14 +26,7 @@
/**
* Encapsulates a request for a particular
23 matches
Mail list logo
