Re: [PR] [SPARK-45927][PYTHON] Update path handling in Python data source [spark]

2023-11-15 Thread via GitHub
allisonwang-db commented on code in PR #43809: URL: https://github.com/apache/spark/pull/43809#discussion_r1394689877 ## sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala: ## @@ -246,7 +246,15 @@ class DataFrameReader private[sql](sparkSession: SparkSession) ex

Re: [PR] [SPARK-45927][PYTHON] Update path handling in Python data source [spark]

2023-11-15 Thread via GitHub
allisonwang-db commented on code in PR #43809: URL: https://github.com/apache/spark/pull/43809#discussion_r1394685914 ## python/pyspark/sql/datasource.py: ## @@ -45,30 +45,19 @@ class DataSource(ABC): """ @final -def __init__( -self, -paths: List[

Re: [PR] [SPARK-45927][PYTHON] Update path handling in Python data source [spark]

2023-11-14 Thread via GitHub
cloud-fan commented on code in PR #43809: URL: https://github.com/apache/spark/pull/43809#discussion_r1393654355 ## sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala: ## @@ -246,7 +246,15 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends

Re: [PR] [SPARK-45927][PYTHON] Update path handling in Python data source [spark]

2023-11-14 Thread via GitHub
cloud-fan commented on code in PR #43809: URL: https://github.com/apache/spark/pull/43809#discussion_r1393642111 ## python/pyspark/sql/datasource.py: ## @@ -45,30 +45,19 @@ class DataSource(ABC): """ @final -def __init__( -self, -paths: List[str],

Re: [PR] [SPARK-45927][PYTHON] Update path handling in Python data source [spark]

2023-11-14 Thread via GitHub
allisonwang-db commented on PR #43809: URL: https://github.com/apache/spark/pull/43809#issuecomment-1811529611 cc @HyukjinKwon @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] [SPARK-45927][PYTHON] Update path handling in Python data source [spark]

2023-11-14 Thread via GitHub
allisonwang-db opened a new pull request, #43809: URL: https://github.com/apache/spark/pull/43809 ### What changes were proposed in this pull request? This PR updates how to handle `path` values from the `load()` method. It changes the DataSource class constructor and add `p