wForget commented on PR #43867:
URL: https://github.com/apache/spark/pull/43867#issuecomment-1826812617
> I think we should only put a rule in posthoc resolution if it needs the
entire plan to be resolved first. `DetermineTableStats` is not the case.
Got it, I'll revert the changes
cloud-fan commented on PR #43867:
URL: https://github.com/apache/spark/pull/43867#issuecomment-1826809747
I think we should only put a rule in posthoc resolution if it needs the
entire plan to be resolved first. `DetermineTableStats` is not the case.
--
This is an automated message from
wForget commented on PR #43867:
URL: https://github.com/apache/spark/pull/43867#issuecomment-1826808784
> > This may also affect other Rules. Since HiveTableRelation is not
resolved, the Project.projectList of the parent plan will not be resolved.
>
> Good point. Why is
wForget commented on PR #43867:
URL: https://github.com/apache/spark/pull/43867#issuecomment-1826721672
> Good point. Why is `DetermineTableStats` a post-hoc resolution rule then...
It was introduced in #17015, I don't see more discussion about it. I willl
try moving it into
cloud-fan commented on PR #43867:
URL: https://github.com/apache/spark/pull/43867#issuecomment-1826351872
> This may also affect other Rules. Since HiveTableRelation is not resolved,
the Project.projectList of the parent plan will not be resolved.
Good point. Why is
wForget commented on PR #43867:
URL: https://github.com/apache/spark/pull/43867#issuecomment-1825329646
> Sorry for the back and forth, but I have a new finding today:
`DetermineTableStats` will always set a table stats to the hive table. That
said, I think we can mark the
wForget commented on PR #43867:
URL: https://github.com/apache/spark/pull/43867#issuecomment-1825235036
> Sorry for the back and forth, but I have a new finding today:
`DetermineTableStats` will always set a table stats to the hive table. That
said, I think we can mark the
cloud-fan commented on PR #43867:
URL: https://github.com/apache/spark/pull/43867#issuecomment-1825224019
Sorry for the back and forth, but I have a new finding today:
`DetermineTableStats` will always set a table stats to the hive table. That
said, I think we can mark the
cloud-fan commented on code in PR #43867:
URL: https://github.com/apache/spark/pull/43867#discussion_r1403999630
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##
@@ -2493,6 +2493,9 @@ class Analyzer(override val catalogManager:
wForget commented on PR #43867:
URL: https://github.com/apache/spark/pull/43867#issuecomment-1825193742
@cloud-fan Could you please continue the review if you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
10 matches
Mail list logo
