yaooqinn commented on PR #43903:
URL: https://github.com/apache/spark/pull/43903#issuecomment-1818735416
> For example, ui-test currently is related to core module only, isn't it?
Not exactly, the current introduced tests are only examples(yes, based on
core), but the module is decou
yaooqinn commented on PR #43903:
URL: https://github.com/apache/spark/pull/43903#issuecomment-1818901899
https://docs.google.com/document/d/1hWl5Q2CNNOjN5Ubyoa28XmpJtDyD9BtGtiEG2TT94rg/edit?usp=sharing
Hi, @dongjoon-hyun, please do a pre-checking for the SPIP doc before I send
it to
dongjoon-hyun commented on PR #43903:
URL: https://github.com/apache/spark/pull/43903#issuecomment-1819949721
Thank you for sharing in advance, @yaooqinn .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dongjoon-hyun commented on PR #43903:
URL: https://github.com/apache/spark/pull/43903#issuecomment-1819958458
In general, it looks good. I added a few comments about a few missing
content, @yaooqinn .
--
This is an automated message from the Apache Git Service.
To respond to the message,
yaooqinn commented on PR #43903:
URL: https://github.com/apache/spark/pull/43903#issuecomment-1831082839
Hi @dongjoon-hyun, thanks for your suggestions and vote for the SPIP. As the
vote result is positive,
https://lists.apache.org/thread/1m94wwkd0wfx9j7rb5p4kf1kgd8rgg89, Would you
like to
dongjoon-hyun commented on PR #43903:
URL: https://github.com/apache/spark/pull/43903#issuecomment-1831086471
Sure, thank you for proceeding the process.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dongjoon-hyun closed pull request #43903: [SPARK-46003][UI][TESTS] Create an
ui-test module with Jest to test ui javascript code
URL: https://github.com/apache/spark/pull/43903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
yaooqinn commented on PR #43903:
URL: https://github.com/apache/spark/pull/43903#issuecomment-1831091175
Thank you again, @dongjoon-hyun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
HyukjinKwon commented on code in PR #43903:
URL: https://github.com/apache/spark/pull/43903#discussion_r1427397294
##
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala:
##
@@ -128,8 +128,15 @@ private[ui] class ExecutorThreadDumpPage(
// scalastyle:o
yaooqinn commented on code in PR #43903:
URL: https://github.com/apache/spark/pull/43903#discussion_r1427469572
##
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala:
##
@@ -128,8 +128,15 @@ private[ui] class ExecutorThreadDumpPage(
// scalastyle:off
dongjoon-hyun commented on code in PR #43903:
URL: https://github.com/apache/spark/pull/43903#discussion_r1467245519
##
core/src/main/resources/org/apache/spark/ui/static/log-view.js:
##
@@ -15,7 +15,9 @@
* limitations under the License.
*/
-/* global $, getBaseURI */
+/*
dongjoon-hyun commented on code in PR #43903:
URL: https://github.com/apache/spark/pull/43903#discussion_r1469159085
##
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala:
##
@@ -35,8 +35,9 @@ private[history] class HistoryPage(parent: HistoryServer)
extends
yaooqinn commented on code in PR #43903:
URL: https://github.com/apache/spark/pull/43903#discussion_r1469179023
##
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala:
##
@@ -35,8 +35,9 @@ private[history] class HistoryPage(parent: HistoryServer)
extends WebUI
dongjoon-hyun commented on code in PR #43903:
URL: https://github.com/apache/spark/pull/43903#discussion_r1469179712
##
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala:
##
@@ -35,8 +35,9 @@ private[history] class HistoryPage(parent: HistoryServer)
extends
14 matches
Mail list logo
