mridulm commented on PR #43998:
URL: https://github.com/apache/spark/pull/43998#issuecomment-1844054833
Merged to master.
Thanks for adding this @hasnain-db !
Thanks for the review @JoshRosen :-)
--
This is an automated message from the Apache Git Service.
To respond to the message,
mridulm closed pull request #43998: [SPARK-46058][CORE] Add separate flag for
privateKeyPassword
URL: https://github.com/apache/spark/pull/43998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hasnain-db commented on PR #43998:
URL: https://github.com/apache/spark/pull/43998#issuecomment-1843956053
@mridulm CI is now green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hasnain-db commented on PR #43998:
URL: https://github.com/apache/spark/pull/43998#issuecomment-1843412884
@mridulm the failure was a docs failure that was unrelated to this PR but
it's been long enough that a rebase is warranted. I'll do that and re-request
review once CI is green again.
mridulm commented on PR #43998:
URL: https://github.com/apache/spark/pull/43998#issuecomment-1841908399
Can you check on the build failure @hasnain-db ? If it unrelated to the PR,
it might be something which is fixed in master (in which case, a rebase should
help).
--
This is an
hasnain-db commented on PR #43998:
URL: https://github.com/apache/spark/pull/43998#issuecomment-1841803523
cc @mridulm in case you want to take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
hasnain-db commented on PR #43998:
URL: https://github.com/apache/spark/pull/43998#issuecomment-1830868251
CI failure is in generating docs but that looks unrelated to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hasnain-db commented on code in PR #43998:
URL: https://github.com/apache/spark/pull/43998#discussion_r1408168103
##
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java:
##
@@ -215,16 +216,27 @@ public Builder privateKey(File privateKey) {
}
hasnain-db commented on PR #43998:
URL: https://github.com/apache/spark/pull/43998#issuecomment-1829034324
Thank you @JoshRosen ! I've fixed the typo and filed a ticket to track the
additional item - you have shown me how to fix it (I'd gotten confused in my
last look). Hope it's OK to
hasnain-db commented on code in PR #43998:
URL: https://github.com/apache/spark/pull/43998#discussion_r1407053124
##
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java:
##
@@ -106,7 +106,7 @@ private void initNettySslContexts(final Builder b)
JoshRosen commented on code in PR #43998:
URL: https://github.com/apache/spark/pull/43998#discussion_r1406993411
##
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java:
##
@@ -106,7 +106,7 @@ private void initNettySslContexts(final Builder b)
JoshRosen commented on code in PR #43998:
URL: https://github.com/apache/spark/pull/43998#discussion_r1406993411
##
common/network-common/src/main/java/org/apache/spark/network/ssl/SSLFactory.java:
##
@@ -106,7 +106,7 @@ private void initNettySslContexts(final Builder b)
JoshRosen commented on code in PR #43998:
URL: https://github.com/apache/spark/pull/43998#discussion_r1406981160
##
docs/security.md:
##
@@ -636,6 +636,14 @@ replaced with one of the above namespaces.
rpc
+
+${ns}.keyPassword
Review Comment:
hasnain-db commented on PR #43998:
URL: https://github.com/apache/spark/pull/43998#issuecomment-1828329150
cc @mridulm @JoshRosen let me know if this makes sense or if there's a way
to do this purely via existing configs (in which case I can abandon this PR and
just update docs)
--
This
hasnain-db opened a new pull request, #43998:
URL: https://github.com/apache/spark/pull/43998
### What changes were proposed in this pull request?
This PR adds a separate way of configuring the private key for RPC SSL
support when using openssl.
### Why are the changes needed?
15 matches
Mail list logo
