dongjoon-hyun commented on PR #44134:
URL: https://github.com/apache/spark/pull/44134#issuecomment-1841165815
Merged to master for Apache Spark 4.0.0.
Thank you, @wangyum , @HyukjinKwon , @wangyum .
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun closed pull request #44134: [SPARK-46069][SQL][FOLLOWUP] Make
sure the cast expression is date type when unwrap timestamp type to date type
URL: https://github.com/apache/spark/pull/44134
--
This is an automated message from the Apache Git Service.
To respond to the message,
wangyum commented on PR #44134:
URL: https://github.com/apache/spark/pull/44134#issuecomment-1840950539
@wankunde Please fix the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wangyum commented on code in PR #44134:
URL: https://github.com/apache/spark/pull/44134#discussion_r1413388859
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala:
##
@@ -139,7 +139,7 @@ object UnwrapCastInBinaryComparison
dongjoon-hyun commented on PR #44134:
URL: https://github.com/apache/spark/pull/44134#issuecomment-1837729449
Oh, @wankunde . It's a compilation failure.
```
[error]
wankunde commented on PR #44134:
URL: https://github.com/apache/spark/pull/44134#issuecomment-1837699068
> Hi, @wankunde .
>
> * The follow-up should not reuse the original PR title. Please use a
proper PR title for your code itself.
>
> ```
> - Cast(fromExp, _, timeZoneId,
