Re: [PR] [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT [spark]

cloud-fan closed pull request #44366: [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT URL: https://github.com/apache/spark/pull/44366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT [spark]

cloud-fan commented on PR #44366: URL: https://github.com/apache/spark/pull/44366#issuecomment-1860433213 The pyspark failure is unrelated, I'm merging this to master, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT [spark]

wankunde commented on code in PR #44366: URL: https://github.com/apache/spark/pull/44366#discussion_r1429588596 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala: ## @@ -406,30 +407,59 @@ class UnwrapCastInBinaryCompar

Re: [PR] [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT [spark]

cloud-fan commented on code in PR #44366: URL: https://github.com/apache/spark/pull/44366#discussion_r1429458511 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala: ## @@ -406,30 +407,59 @@ class UnwrapCastInBinaryCompa

Re: [PR] [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT [spark]

wankunde commented on code in PR #44366: URL: https://github.com/apache/spark/pull/44366#discussion_r1429167102 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala: ## @@ -406,30 +407,59 @@ class UnwrapCastInBinaryCompar

Re: [PR] [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT [spark]

cloud-fan commented on code in PR #44366: URL: https://github.com/apache/spark/pull/44366#discussion_r1428507820 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala: ## @@ -406,30 +407,59 @@ class UnwrapCastInBinaryCompa

Re: [PR] [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT [spark]

wankunde commented on code in PR #44366: URL: https://github.com/apache/spark/pull/44366#discussion_r1427783240 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala: ## @@ -406,30 +407,62 @@ class UnwrapCastInBinaryCompar

Re: [PR] [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT [spark]

cloud-fan commented on code in PR #44366: URL: https://github.com/apache/spark/pull/44366#discussion_r1427728692 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala: ## @@ -406,30 +407,62 @@ class UnwrapCastInBinaryCompa

[PR] [SPARK-46069][SQL][FOLLOWUP] Simplify the code and add more UT [spark]

wankunde opened a new pull request, #44366: URL: https://github.com/apache/spark/pull/44366 ### What changes were proposed in this pull request? * Use `falseIfNotNull` method to simplify the code * Add UT for `isStartOfDay = true` cases ### Why are the changes needed?