dbatomic commented on PR #44110:
URL: https://github.com/apache/spark/pull/44110#issuecomment-1845566488
> @dbatomic Does this suffer from the same issue?
>
>
https://github.com/apache/spark/blob/b4d90dd2a622beda542a7ce1ee15af9f312f9724/sql/api/src/main/scala/org/apache/spark/sql/cata
MaxGekk commented on PR #44110:
URL: https://github.com/apache/spark/pull/44110#issuecomment-1845496117
@dbatomic Does this suffer from the same issue?
https://github.com/apache/spark/blob/b4d90dd2a622beda542a7ce1ee15af9f312f9724/sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/S
beliefer commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1418184528
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
cloud-fan closed pull request #44110: [SPARK-46173][SQL] Skipping trimAll call
during date parsing
URL: https://github.com/apache/spark/pull/44110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cloud-fan commented on PR #44110:
URL: https://github.com/apache/spark/pull/44110#issuecomment-1843090919
The docker integration test failure is unrelated. merging to master, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
cloud-fan commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1417489483
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && dig
dbatomic commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1417456888
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
beliefer commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1417100176
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
beliefer commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1417100176
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
beliefer commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1417096351
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
dbatomic commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1417024325
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
dbatomic commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1416987444
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
cloud-fan commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1416657435
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && dig
cloud-fan commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1416657240
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && dig
beliefer commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1416536094
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,35 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
dbatomic commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1415790402
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,41 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
beliefer commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1415543362
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,41 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
dbatomic commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1415381396
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
cloud-fan commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1414260156
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && dig
beliefer commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413764128
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
dbatomic commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413761230
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
beliefer commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413760894
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
cloud-fan commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413750468
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && dig
cloud-fan commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413748213
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && dig
cloud-fan commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413746879
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && dig
cloud-fan commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413744707
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && dig
beliefer commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413737755
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,32 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
dbatomic commented on PR #44110:
URL: https://github.com/apache/spark/pull/44110#issuecomment-1838423819
> > Looking for feedback if we want to keep the benchmark, given that this
is a rather esoteric edge case.
>
> I am ok to exclude the benchmark for the pretty specific case from th
MaxGekk commented on PR #44110:
URL: https://github.com/apache/spark/pull/44110#issuecomment-1838402901
> Looking for feedback if we want to keep the benchmark, given that this is
a rather esoteric edge case.
I am ok to exclude the benchmark for the pretty specific case from the PR.
dbatomic commented on PR #44110:
URL: https://github.com/apache/spark/pull/44110#issuecomment-1838267647
> > The change also includes a small unit benchmark for this particular case.
>
> I wonder of other benchmarks. Do you observe perf regressions? I am asking
just in case.
I
dbatomic commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413654244
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,28 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
MaxGekk commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413582904
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,28 @@ trait SparkDateTimeUtils {
(segment == 0 && digit
MaxGekk commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413574114
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,28 @@ trait SparkDateTimeUtils {
(segment == 0 && digit
dbatomic commented on code in PR #44110:
URL: https://github.com/apache/spark/pull/44110#discussion_r1413561777
##
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala:
##
@@ -305,21 +305,28 @@ trait SparkDateTimeUtils {
(segment == 0 && digi
34 matches
Mail list logo
