Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415517518 ## core/src/main/scala/org/apache/spark/ui/UIUtils.scala: ## @@ -431,7 +431,7 @@ private[spark] object UIUtils extends Logging { } val headerRow: Seq[No

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415496286 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala: ## @@ -388,7 +388,7 @@ object CompactibleFileStreamLog { }

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415496286 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala: ## @@ -388,7 +388,7 @@ object CompactibleFileStreamLog { }

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415490110 ## mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala: ## @@ -187,7 +187,7 @@ class GaussianMixture private ( case None =>

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
zhengruifeng commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415479079 ## mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala: ## @@ -187,7 +187,7 @@ class GaussianMixture private ( case None =>

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415455947 ## mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixture.scala: ## @@ -187,7 +187,7 @@ class GaussianMixture private ( case None =>

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415331079 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -417,7 +417,7 @@ case class StructType(fields: Array[StructField]) extends DataType wi

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415266748 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -417,7 +417,7 @@ case class StructType(fields: Array[StructField]) extends DataType wi

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
yaooqinn commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415318597 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -417,7 +417,7 @@ case class StructType(fields: Array[StructField]) extends DataType with

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415263533 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -417,7 +417,7 @@ case class StructType(fields: Array[StructField]) extends DataType wi

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415266748 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -417,7 +417,7 @@ case class StructType(fields: Array[StructField]) extends DataType wi

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415263533 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -417,7 +417,7 @@ case class StructType(fields: Array[StructField]) extends DataType wi

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415263533 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -417,7 +417,7 @@ case class StructType(fields: Array[StructField]) extends DataType wi

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
yaooqinn commented on code in PR #44179: URL: https://github.com/apache/spark/pull/44179#discussion_r1415256193 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -417,7 +417,7 @@ case class StructType(fields: Array[StructField]) extends DataType with

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions [spark]

2023-12-05 Thread via GitHub
LuciferYang commented on PR #44179: URL: https://github.com/apache/spark/pull/44179#issuecomment-1840380311 Could you review this PR? @cloud-fan @dongjoon-hyun @yaooqinn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [SPARK-46263][SQL][SS][ML][MLLIB][UI] Clean up unnecessary `SeqOps.view` and `ArrayOps.view` conversions. [spark]

2023-12-04 Thread via GitHub
LuciferYang commented on PR #44179: URL: https://github.com/apache/spark/pull/44179#issuecomment-1840132785 Let me double check the change first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th