Re: [PR] [SPARK-46294][SQL] Clean up semantics of init vs zero value [spark]

2023-12-14 Thread via GitHub
cloud-fan closed pull request #44222: [SPARK-46294][SQL] Clean up semantics of init vs zero value URL: https://github.com/apache/spark/pull/44222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-46294][SQL] Clean up semantics of init vs zero value [spark]

2023-12-14 Thread via GitHub
cloud-fan commented on PR #44222: URL: https://github.com/apache/spark/pull/44222#issuecomment-1856973646 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [SPARK-46294][SQL] Clean up semantics of init vs zero value [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44222: URL: https://github.com/apache/spark/pull/44222#discussion_r1426175626 ## sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala: ## @@ -37,36 +37,47 @@ import org.apache.spark.util.AccumulatorContext.internOption

Re: [PR] [SPARK-46294][SQL] Clean up semantics of init vs zero value [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44222: URL: https://github.com/apache/spark/pull/44222#discussion_r1426174905 ## sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala: ## @@ -37,36 +37,47 @@ import org.apache.spark.util.AccumulatorContext.internOption

Re: [PR] [SPARK-46294][SQL] Clean up semantics of init vs zero value [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44222: URL: https://github.com/apache/spark/pull/44222#discussion_r1426171943 ## sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala: ## @@ -37,36 +37,47 @@ import org.apache.spark.util.AccumulatorContext.internOption

Re: [PR] [SPARK-46294][SQL] Clean up semantics of init vs zero value [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44222: URL: https://github.com/apache/spark/pull/44222#discussion_r1426171810 ## sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala: ## @@ -37,36 +37,47 @@ import org.apache.spark.util.AccumulatorContext.internOption