Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-12 Thread via GitHub
cloud-fan commented on PR #44302: URL: https://github.com/apache/spark/pull/44302#issuecomment-1852930395 thanks, merging to master/3.5! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-12 Thread via GitHub
cloud-fan closed pull request #44302: [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults URL: https://github.com/apache/spark/pull/44302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-12 Thread via GitHub
dtenedor commented on PR #44302: URL: https://github.com/apache/spark/pull/44302#issuecomment-1852588610 @cloud-fan all tests are passing now: ![image](https://github.com/apache/spark/assets/99207096/c22520b2-334c-446d-8f65-7edcaa44b7c1) -- This is an automated message from the Ap

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-12 Thread via GitHub
dtenedor commented on PR #44302: URL: https://github.com/apache/spark/pull/44302#issuecomment-1852484876 > Can you retrigger the test? The failed test seems unrelated. @cloud-fan I started this, it is in progress now: ![image](https://github.com/apache/spark/assets/99207096/7d6

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-12 Thread via GitHub
dtenedor commented on code in PR #44302: URL: https://github.com/apache/spark/pull/44302#discussion_r1424341068 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -374,6 +374,7 @@ case class AlterTableChangeColumnCommand( // TODO: support chang

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-12 Thread via GitHub
beliefer commented on code in PR #44302: URL: https://github.com/apache/spark/pull/44302#discussion_r1423606480 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -374,6 +374,7 @@ case class AlterTableChangeColumnCommand( // TODO: support chang

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-11 Thread via GitHub
cloud-fan commented on PR #44302: URL: https://github.com/apache/spark/pull/44302#issuecomment-1851407507 Can you retrigger the test? The failed test seems unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-11 Thread via GitHub
dtenedor commented on code in PR #44302: URL: https://github.com/apache/spark/pull/44302#discussion_r1423244953 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -374,6 +374,7 @@ case class AlterTableChangeColumnCommand( // TODO: support chang

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-11 Thread via GitHub
cloud-fan commented on code in PR #44302: URL: https://github.com/apache/spark/pull/44302#discussion_r1423175769 ## sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala: ## @@ -2608,6 +2608,25 @@ class InsertSuite extends DataSourceTest with SharedSparkSession

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-11 Thread via GitHub
cloud-fan commented on code in PR #44302: URL: https://github.com/apache/spark/pull/44302#discussion_r1423174851 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala: ## @@ -374,6 +374,7 @@ case class AlterTableChangeColumnCommand( // TODO: support chan

Re: [PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-11 Thread via GitHub
dtenedor commented on PR #44302: URL: https://github.com/apache/spark/pull/44302#issuecomment-1850952795 cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] [SPARK-46370][SQL] Fix bug when querying from table after changing column defaults [spark]

2023-12-11 Thread via GitHub
dtenedor opened a new pull request, #44302: URL: https://github.com/apache/spark/pull/44302 ### What changes were proposed in this pull request? This PR fixes a bug when querying from table after changing defaults: ``` drop table if exists t; create table t(i int, s string