yaooqinn commented on code in PR #44293:
URL: https://github.com/apache/spark/pull/44293#discussion_r1423455231
##
dev/.rat-excludes:
##
@@ -48,32 +44,17 @@ jquery.mustache.js
pyspark-coverage-site/*
cloudpickle/*
join.py
-SparkExprTyper.scala
SparkILoop.scala
-SparkILoopIni
yaooqinn commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1851357727
Personally, I don't think it's unnecessary to clean them as they never
bother me through development.
--
This is an automated message from the Apache Git Service.
To respond to the mes
dongjoon-hyun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1868387554
I agree with @yaooqinn .
To @panbingkun , could you elaborate a little more about this? I don't
understand what you meant by this.
> To avoid misunderstandings caused by ou
panbingkun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1868643987
> I agree with @yaooqinn .
>
> To @panbingkun , could you elaborate a little more about this? I don't
understand what you meant by this.
>
> > To avoid misunderstandings c
dongjoon-hyun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1869147941
To @panbingkun , the above description should be in the PR description.
Please add them into the PR description to be complete next time.
In addition, this PR is wrong as @yao
panbingkun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1869178216
> To @panbingkun , the above description should be in the PR description.
Please add them into the PR description to be complete next time.
>
> In addition, this PR is wrong as @
panbingkun commented on code in PR #44293:
URL: https://github.com/apache/spark/pull/44293#discussion_r1436200013
##
dev/.rat-excludes:
##
@@ -4,8 +4,6 @@ cache
.gitattributes
.project
.classpath
-.mima-excludes
Review Comment:
After this PR
https://github.com/apache/spa
panbingkun commented on code in PR #44293:
URL: https://github.com/apache/spark/pull/44293#discussion_r1436200250
##
dev/.rat-excludes:
##
@@ -4,8 +4,6 @@ cache
.gitattributes
.project
.classpath
-.mima-excludes
-.generated-mima-excludes
Review Comment:
After this PR
htt
panbingkun commented on code in PR #44293:
URL: https://github.com/apache/spark/pull/44293#discussion_r1436200013
##
dev/.rat-excludes:
##
@@ -4,8 +4,6 @@ cache
.gitattributes
.project
.classpath
-.mima-excludes
Review Comment:
After this PR
https://github.com/apache/spa
panbingkun closed pull request #44293: [SPARK-46371][BUILD] Clean up outdated
items in `.rat-excludes`
URL: https://github.com/apache/spark/pull/44293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
panbingkun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1869207055
> To @panbingkun , the above description should be in the PR description.
Please add them into the PR description to be complete next time.
>
> In addition, this PR is wrong as @
dongjoon-hyun closed pull request #44293: [SPARK-46371][BUILD] Clean up
outdated items in `.rat-excludes`
URL: https://github.com/apache/spark/pull/44293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun commented on PR #44293:
URL: https://github.com/apache/spark/pull/44293#issuecomment-1869355931
Merged to master. Thank you, @panbingkun and @yaooqinn .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
13 matches
Mail list logo
