cloud-fan commented on PR #44310:
URL: https://github.com/apache/spark/pull/44310#issuecomment-1852552188
thanks for the review, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cloud-fan closed pull request #44310: [SPARK-46378][SQL] Still remove Sort
after converting Aggregate to Project
URL: https://github.com/apache/spark/pull/44310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
beliefer commented on code in PR #44310:
URL: https://github.com/apache/spark/pull/44310#discussion_r1423864377
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -769,7 +769,9 @@ object LimitPushDown extends Rule[LogicalPlan] {
beliefer commented on code in PR #44310:
URL: https://github.com/apache/spark/pull/44310#discussion_r1423845505
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -769,7 +769,9 @@ object LimitPushDown extends Rule[LogicalPlan] {
beliefer commented on code in PR #44310:
URL: https://github.com/apache/spark/pull/44310#discussion_r1423845505
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -769,7 +769,9 @@ object LimitPushDown extends Rule[LogicalPlan] {
ulysses-you commented on code in PR #44310:
URL: https://github.com/apache/spark/pull/44310#discussion_r1423780895
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -769,7 +769,9 @@ object LimitPushDown extends Rule[LogicalPlan] {
beliefer commented on code in PR #44310:
URL: https://github.com/apache/spark/pull/44310#discussion_r1423598716
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -769,7 +769,9 @@ object LimitPushDown extends Rule[LogicalPlan] {
cloud-fan commented on PR #44310:
URL: https://github.com/apache/spark/pull/44310#issuecomment-1851464587
cc @wangyum @ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
cloud-fan opened a new pull request, #44310:
URL: https://github.com/apache/spark/pull/44310
### What changes were proposed in this pull request?
This is a follow-up of https://github.com/apache/spark/pull/33397 to avoid
sub-optimal plans. After converting `Aggregate` to `Proj
