Re: [PR] [SPARK-46393][SQL] Classify exceptions in the JDBC table catalog [spark]

2023-12-15 Thread via GitHub
MaxGekk commented on PR #44335: URL: https://github.com/apache/spark/pull/44335#issuecomment-1857582179 @srielau @cloud-fan The small PR with assigned names is ready: https://github.com/apache/spark/pull/44358 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-46393][SQL] Classify exceptions in the JDBC table catalog [spark]

2023-12-14 Thread via GitHub
srielau commented on PR #44335: URL: https://github.com/apache/spark/pull/44335#issuecomment-1856019413 Opened: https://issues.apache.org/jira/browse/SPARK-46410 as follow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [SPARK-46393][SQL] Classify exceptions in the JDBC table catalog [spark]

2023-12-14 Thread via GitHub
MaxGekk closed pull request #44335: [SPARK-46393][SQL] Classify exceptions in the JDBC table catalog URL: https://github.com/apache/spark/pull/44335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [SPARK-46393][SQL] Classify exceptions in the JDBC table catalog [spark]

2023-12-14 Thread via GitHub
MaxGekk commented on PR #44335: URL: https://github.com/apache/spark/pull/44335#issuecomment-1855358235 Merging to master. Thank you, all for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-46393][SQL] Classify exceptions in the JDBC table catalog [spark]

2023-12-13 Thread via GitHub
MaxGekk commented on PR #44335: URL: https://github.com/apache/spark/pull/44335#issuecomment-1855346272 > At a minimum we could give: _LEGACY_ERROR_TEMP_3064 a proper name and each of these invocations picks a subclass. There are no tests at all for the cases where JDBC op fails. I be

Re: [PR] [SPARK-46393][SQL] Classify exceptions in the JDBC table catalog [spark]

2023-12-13 Thread via GitHub
srielau commented on PR #44335: URL: https://github.com/apache/spark/pull/44335#issuecomment-1855113908 > @srielau This seems like a lot of work as we need to understand different errors from different databases. Shall we have a general error class name as the fallback? Each JDBC dialect ca

Re: [PR] [SPARK-46393][SQL] Classify exceptions in the JDBC table catalog [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on PR #44335: URL: https://github.com/apache/spark/pull/44335#issuecomment-1855106022 @srielau This seems like a lot of work as we need to understand different errors from different databases. Shall we have a general error class name as the fallback? Each JDBC dialect ca

Re: [PR] [SPARK-46393][SQL] Classify exceptions in the JDBC table catalog [spark]

2023-12-13 Thread via GitHub
srielau commented on PR #44335: URL: https://github.com/apache/spark/pull/44335#issuecomment-1854656969 @MaxGekk Is this just doing: /** * Gets a dialect exception, classifies it and wraps it by `AnalysisException`. * @param message The error message to be placed to the re