github-actions[bot] commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-2062764367
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
caicancai closed pull request #44357: [SPARK-46408][SQL] Support date_sub on
V2ExpressionBuilder
URL: https://github.com/apache/spark/pull/44357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1856018097
I will add supplementary tests later, because I made the modification in 3.4
before, and I still have a question why my cli always fails.
--
This is an automated message from the Apac
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1857434549
cc @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1859146374
> I think this PR is incomplete. You should select a builtin JDBC dialect
(e.g. H2, Postgres and so on) to push down the expression to JDBC query and add
some test cases.
Hello,
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1859566710
> Hello, thank you very much for your review. There is no mysql test in
JDBCV2Suite. I can only imitate date_add and create such a test in h2.
No. You can't. H2 doesn't support `da
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1859617257
> > Hello, thank you very much for your review. There is no mysql test in
JDBCV2Suite. I can only imitate date_add and create such a test in h2.
>
> No. You can't. H2 doesn't supp
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1860153777
> Thanks for your reply, but v2.MySQLIntegrationSuite does not have related
function tests (such as date_add, datediff, etc.), and may need to modify the
MySQLDialect, you need me to add
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1862067057
> > Thanks for your reply, but v2.MySQLIntegrationSuite does not have
related function tests (such as date_add, datediff, etc.), and may need to
modify the MySQLDialect, you need me to
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1864457090
@caicancai `v2.MySQLIntegrationSuite` has own method, please refer
`V2JDBCTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873229188
Sorry, I was quite busy some time ago and didn’t have time to follow up on
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873230108
@beliefer Hello, Happy New Year. I found that neither date_add nor date_sub
is pushed down. My pr only supports the expression date_sub. Do I need to
support the push down to mysql?
-
beliefer commented on code in PR #44357:
URL: https://github.com/apache/spark/pull/44357#discussion_r1439010177
##
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/MySQLIntegrationSuite.scala:
##
@@ -163,4 +164,29 @@ class MySQLIntegrationSuite exte
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873295524
Please check the failure tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873296989
> Please check the failure tests.
Thank you for your reply. I d
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873341258
I found a bug when trying to push down date_add these date functions
`date_add(date1, 1) = '2022-05-20'` will change `'2022-05-20' to 19132`
before executing build(expr)
This code adaptation will be entered in the 3.4 branch. I will check
specifically w
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873772219
@caicancai You can retriever the GA tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873773507
> @caicancai You can retrigger the GA tests.
I'm not sure how this works, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873907460
--
This is an automated message from the Apache Git Service.
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873908116
--
This is an automated message from the Apache Git Service.
To re
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873910396
--
This is an automated message from the Apache Git Service.
To re
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873910933
--
This is an automated message from the Apache Git Service.
To re
beliefer commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-187395
--
This is an automated message from the Apache Git Service.
To re
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1873981248
@beliefer Thank you very much for your patient reply, but cli still se
caicancai commented on PR #44357:
URL: https://github.com/apache/spark/pull/44357#issuecomment-1874078036
>
