yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1905667118
It's Ok to be reverted simply by
[2aed25b](https://github.com/apache/spark/commit/2aed25b15dbac44dd43caceb908b77f998a0634d)
[20da7c0](https://github.com/apache/spark/commit/20da7c0f3c44
cloud-fan commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462973783
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
yaooqinn commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462905132
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
cloud-fan commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462870595
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
yaooqinn commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462800905
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1905394773
For HMS, A pre-step of `getMSC()` wrapped together might also throw ex
before the meta API
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
cloud-fan commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1462773777
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
cloud-fan commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1905358925
Shall I add back `e.getMessage.contains("Unable to fetch table")`? This is
verified on production that AWS Glue may throw such exceptions while
`throwException` is false.
--
This is
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1905342167
As #44831 reported, we should revert this first. Hive getTable is an RPC
call, it could result in various client-server issues that the client shall be
aware of? WDYT @cloud-fan ?
--
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857683044
Thanks. Merged to master 3.5 and 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
yaooqinn closed pull request #44364: [SPARK-46417][SQL] Do not fail when
calling hive.getTable and throwException is false
URL: https://github.com/apache/spark/pull/44364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857541417
NVM, I was wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
cloud-fan commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857521039
@yaooqinn which null value were you referencing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
cloud-fan commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1427725075
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
yaooqinn commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857512068
It looks like we do not handle `null` values at the caller side, this PR
increases NPE risks
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
yaooqinn commented on code in PR #44364:
URL: https://github.com/apache/spark/pull/44364#discussion_r1427622193
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##
@@ -923,7 +923,13 @@ private[client] class Shim_v2_0 extends Shim with Logging {
cloud-fan commented on PR #44364:
URL: https://github.com/apache/spark/pull/44364#issuecomment-1857326100
@yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
cloud-fan opened a new pull request, #44364:
URL: https://github.com/apache/spark/pull/44364
### What changes were proposed in this pull request?
Uses can set up their own HMS and let Spark connects to it. We have no
control over it and somtimes it's not even Hive but just a H
18 matches
Mail list logo
