Re: [PR] [SPARK-46524][SQL] Improve error messages for invalid save mode [spark]

2024-01-03 Thread via GitHub
MaxGekk closed pull request #44508: [SPARK-46524][SQL] Improve error messages for invalid save mode URL: https://github.com/apache/spark/pull/44508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [SPARK-46524][SQL] Improve error messages for invalid save mode [spark]

2024-01-03 Thread via GitHub
MaxGekk commented on PR #44508: URL: https://github.com/apache/spark/pull/44508#issuecomment-1875315769 +1, LGTM. Merging to master. Thank you, @allisonwang-db and @HyukjinKwon for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [SPARK-46524][SQL] Improve error messages for invalid save mode [spark]

2024-01-02 Thread via GitHub
MaxGekk commented on PR #44508: URL: https://github.com/apache/spark/pull/44508#issuecomment-1873743038 @allisonwang-db Please, fix at least R tests: ``` ══ Failed ══ ── 1. Failure ('test_sparkSQL.R:1416:5'): test H

Re: [PR] [SPARK-46524][SQL] Improve error messages for invalid save mode [spark]

2024-01-01 Thread via GitHub
allisonwang-db commented on PR #44508: URL: https://github.com/apache/spark/pull/44508#issuecomment-1873652387 @MaxGekk updated! PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-46524][SQL] Improve error messages for invalid save mode [spark]

2023-12-29 Thread via GitHub
MaxGekk commented on PR #44508: URL: https://github.com/apache/spark/pull/44508#issuecomment-1871843480 @allisonwang-db The test failures are related to your changes, please, fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-46524][SQL] Improve error messages for invalid save mode [spark]

2023-12-28 Thread via GitHub
MaxGekk commented on PR #44508: URL: https://github.com/apache/spark/pull/44508#issuecomment-1871751285 @allisonwang-db Please, update PR's description according to your recent changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [SPARK-46524][SQL] Improve error messages for invalid save mode [spark]

2023-12-27 Thread via GitHub
MaxGekk commented on code in PR #44508: URL: https://github.com/apache/spark/pull/44508#discussion_r1437158897 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -2256,6 +2256,12 @@ ], "sqlState" : "42613" }, + "INVALID_SAVE_MODE" : { +"message"

[PR] [SPARK-46524][SQL] Improve error messages for invalid save mode [spark]

2023-12-27 Thread via GitHub
allisonwang-db opened a new pull request, #44508: URL: https://github.com/apache/spark/pull/44508 ### What changes were proposed in this pull request? This PR improves the error messages when writing a data frame with an invalid save mode. ### Why are the changes needed