Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-10-12 Thread via GitHub
github-actions[bot] closed pull request #44767: [SPARK-46741][SQL] Cache Table with CTE won't work URL: https://github.com/apache/spark/pull/44767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-10-11 Thread via GitHub
github-actions[bot] commented on PR #44767: URL: https://github.com/apache/spark/pull/44767#issuecomment-2408262816 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-07-02 Thread via GitHub
AngersZh commented on PR #44767: URL: https://github.com/apache/spark/pull/44767#issuecomment-2204898273 > what was behaviour before? Would be great to show the result before/after For the query in `cache.sql` ``` EXPLAIN EXTENDED SELECT * FROM cache_nested_cte_table ```

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-07-02 Thread via GitHub
HyukjinKwon commented on PR #44767: URL: https://github.com/apache/spark/pull/44767#issuecomment-2204787858 what was behaviour before? Would be great to show the result before/after -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-06-11 Thread via GitHub
AngersZh commented on PR #44767: URL: https://github.com/apache/spark/pull/44767#issuecomment-2160081906 ping @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-05-16 Thread via GitHub
AngersZh commented on PR #44767: URL: https://github.com/apache/spark/pull/44767#issuecomment-2114228690 ping @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-05-14 Thread via GitHub
AngersZh commented on PR #44767: URL: https://github.com/apache/spark/pull/44767#issuecomment-2109748573 @cloud-fan Changed follow the discussion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-05-13 Thread via GitHub
AngersZh commented on PR #44767: URL: https://github.com/apache/spark/pull/44767#issuecomment-2109143816 ping @cloud-fan @yaooqinn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-05-08 Thread via GitHub
AngersZh commented on PR #44767: URL: https://github.com/apache/spark/pull/44767#issuecomment-2100528131 ping @cloud-fan Changed follow your PR, pls take a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-23 Thread via GitHub
AngersZh commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1464219993 ## sql/core/src/test/resources/sql-tests/inputs/cache.sql: ## @@ -0,0 +1,33 @@ +CREATE TEMPORARY VIEW t1 AS SELECT * FROM VALUES (0, 0), (1, 1), (2, 2) AS t(c1, c

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-23 Thread via GitHub
AngersZh commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1464220112 ## sql/core/src/test/resources/sql-tests/inputs/cache.sql: ## @@ -0,0 +1,33 @@ +CREATE TEMPORARY VIEW t1 AS SELECT * FROM VALUES (0, 0), (1, 1), (2, 2) AS t(c1, c

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-23 Thread via GitHub
cloud-fan commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1463229851 ## sql/core/src/test/resources/sql-tests/inputs/cache.sql: ## @@ -0,0 +1,33 @@ +CREATE TEMPORARY VIEW t1 AS SELECT * FROM VALUES (0, 0), (1, 1), (2, 2) AS t(c1, c2);

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-23 Thread via GitHub
cloud-fan commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1463229360 ## sql/core/src/test/resources/sql-tests/inputs/cache.sql: ## @@ -0,0 +1,33 @@ +CREATE TEMPORARY VIEW t1 AS SELECT * FROM VALUES (0, 0), (1, 1), (2, 2) AS t(c1, c2);

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-23 Thread via GitHub
AngersZh commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1463025288 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -910,6 +910,30 @@ case class WithCTE(plan: LogicalPla

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-18 Thread via GitHub
AngersZh commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1458506743 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -910,6 +910,30 @@ case class WithCTE(plan: LogicalPla

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-18 Thread via GitHub
cloud-fan commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1458257373 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -910,6 +910,30 @@ case class WithCTE(plan: LogicalPlan,

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-18 Thread via GitHub
AngersZh commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1458255607 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -910,6 +910,30 @@ case class WithCTE(plan: LogicalPla

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-18 Thread via GitHub
cloud-fan commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1458253653 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -910,6 +910,30 @@ case class WithCTE(plan: LogicalPlan,

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-18 Thread via GitHub
cloud-fan commented on code in PR #44767: URL: https://github.com/apache/spark/pull/44767#discussion_r1458253319 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -910,6 +910,30 @@ case class WithCTE(plan: LogicalPlan,

Re: [PR] [SPARK-46741][SQL] Cache Table with CTE won't work [spark]

2024-01-17 Thread via GitHub
AngersZh commented on PR #44767: URL: https://github.com/apache/spark/pull/44767#issuecomment-1897673599 How about current? @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe