Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

cloud-fan closed pull request #45389: [SPARK-46835][SQL][Collations] Join support for non-binary collations URL: https://github.com/apache/spark/pull/45389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

cloud-fan commented on PR #45389: URL: https://github.com/apache/spark/pull/45389#issuecomment-1980164987 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

dbatomic commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1513005783 ## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala: ## @@ -205,6 +206,12 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

dbatomic commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1513004663 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -597,4 +597,49 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanH

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

dbatomic commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1513002552 ## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala: ## @@ -228,37 +235,46 @@ abstract class SparkStrategies extends QueryPlanner[SparkPla

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

GideonPotok commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1512907243 ## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala: ## @@ -228,37 +235,46 @@ abstract class SparkStrategies extends QueryPlanner[Spark

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

GideonPotok commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1512899167 ## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala: ## @@ -205,6 +206,12 @@ abstract class SparkStrategies extends QueryPlanner[SparkP

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

cloud-fan commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1512887045 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -597,4 +597,49 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlan

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

dbatomic commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1512870997 ## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala: ## @@ -228,9 +235,10 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

dbatomic commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1512869445 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -597,4 +597,49 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanH

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

cloud-fan commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1512858148 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -597,4 +597,49 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlan

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

cloud-fan commented on code in PR #45389: URL: https://github.com/apache/spark/pull/45389#discussion_r1512856918 ## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala: ## @@ -228,9 +235,10 @@ abstract class SparkStrategies extends QueryPlanner[SparkPla

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

dbatomic commented on PR #45389: URL: https://github.com/apache/spark/pull/45389#issuecomment-1978807250 > Why does this issue not seem to exist when I search it? https://issues.apache.org/jira/issues/?jql=project%20%3D%20SPARK%20AND%20text%20~%20SPARK-46835 @GideonPotok - Not sure, h

Re: [PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

GideonPotok commented on PR #45389: URL: https://github.com/apache/spark/pull/45389#issuecomment-1978798573 Why does this issue not seem to exist when I search it? https://issues.apache.org/jira/issues/?jql=project%20%3D%20SPARK%20AND%20text%20~%20SPARK-46835 -- This is an automated mes

[PR] [SPARK-46835][SQL][Collations] Join support for non-binary collations [spark]

dbatomic opened a new pull request, #45389: URL: https://github.com/apache/spark/pull/45389 ### What changes were proposed in this pull request? This change introduces support for JOINs for StringType that doesn't follow binary collations (e.g. *LCASE collations). For i